standard log format of bsp module and improve some error message #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #47 +/- ## ============================================ + Coverage 83.14% 83.30% +0.15% - Complexity 1362 1377 +15 ============================================ Files 149 150 +1 Lines 4522 4588 +66 Branches 379 381 +2 ============================================ + Hits 3760 3822 +62 Misses 534 534 - Partials 228 232 +4 Continue to review full report at Codecov.
|
houzhizhen reviewed May 10, 2021
| LOG.info("Wait for keys with prefix '{}', expect {} actual {}", | ||
| prefixSeq.toString(ENCODING), count, keyValues.size()); | ||
| LOG.info("Wait for keys with prefix '{}' and timeout {}ms, " + | ||
| "expect {} keys bug actual got {} keys", |
| this.workerInfo.id()); | ||
| this.bspClient().put(path, Constants.EMPTY_BYTES); | ||
| LOG.info("Worker {} input done", this.workerInfo.id()); | ||
| LOG.info("Worker({}) set input-done: {}", this.workerInfo.id()); |
There was a problem hiding this comment.
remove ':{}' at end of "Worker({}) set input-done: {}"
coderzc approved these changes May 10, 2021
houzhizhen approved these changes May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.