add rpc support #36
add rpc support #36
Conversation
| if (clazz == Null.class) { | ||
| if (requiredNotNull) { | ||
| throw new ComputerException( | ||
| "Please config required option '%s'", clazzOption.name()); |
There was a problem hiding this comment.
align with ComputerException
There was a problem hiding this comment.
it will cause to exceed 80 chars
| this.config = config; | ||
| // TODO: Start data-transport server and get its host and port. | ||
| this.workerInfo = new ContainerInfo(0, "localhost", 0, 8004); | ||
| |
There was a problem hiding this comment.
check inited = false firstly
| | ||
| @Override | ||
| public String name() { | ||
| return "mack_master_input"; |
| | ||
| @Override | ||
| public String name() { | ||
| return "mack_worker_input"; |
| // TODO: calls LoadService to load vertices and edges parallel | ||
| } | ||
| | ||
| public WorkerStat mergeGraph() { |
There was a problem hiding this comment.
WorkerInputManager only read vertices from HG, and VertexReceiveManager mergeGraph after received all graph data.
There was a problem hiding this comment.
ok, can move mergeGraph() to VertexReceiveManager in the future
| } | ||
| | ||
| private void checkInited() { | ||
| E.checkArgument(this.inited, "The %s has not been initialized ", this); |
There was a problem hiding this comment.
remove space after "initialized"
| }); | ||
| | ||
| pool.submit(() -> { | ||
| UnitTestBase.updateWithRequiredOptions( |
There was a problem hiding this comment.
UnitTestBase.updateWithRequiredOptions only once, as it will replace the global value.
There was a problem hiding this comment.
the master needs RPC_SERVER_HOST and the worker needs RPC_REMOTE_URL
Codecov Report
@@ Coverage Diff @@ ## master #36 +/- ## ============================================ + Coverage 80.55% 80.89% +0.34% - Complexity 913 956 +43 ============================================ Files 100 105 +5 Lines 3111 3230 +119 Branches 287 282 -5 ============================================ + Hits 2506 2613 +107 - Misses 478 483 +5 - Partials 127 134 +7
Continue to review full report at Codecov.
|
3 participants
No description provided.