Skip to content

Conversation

simon824
Copy link
Member

@simon824 simon824 commented Dec 8, 2023

Purpose of the PR

  • close #xxx

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
@imbajin
Copy link
Member

imbajin commented Dec 8, 2023

merge after #286 (Due to CI blocked 😄)

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (e0b484a) 85.03% compared to head (4d90e9c) 84.91%.
Report is 1 commits behind head on master.

Files Patch % Lines
...apache/hugegraph/computer/core/bsp/EtcdClient.java 52.38% 6 Missing and 4 partials ⚠️
.../hugegraph/computer/core/worker/WorkerService.java 85.93% 8 Missing and 1 partial ⚠️
.../hugegraph/computer/core/master/MasterService.java 50.00% 4 Missing and 3 partials ⚠️
...raph/computer/k8s/operator/OperatorEntrypoint.java 81.81% 2 Missing ⚠️
...h/computer/core/network/session/ClientSession.java 66.66% 1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## master #293 +/- ## ============================================ - Coverage 85.03% 84.91% -0.12%  - Complexity 3296 3298 +2  ============================================ Files 349 349 Lines 12485 12500 +15 Branches 1130 1132 +2 ============================================ - Hits 10616 10614 -2  - Misses 1329 1343 +14  - Partials 540 543 +3 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@simon824 simon824 requested a review from coderzc December 11, 2023 10:30
@coderzc coderzc merged commit 75224d2 into apache:master Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants