add Partitioner and HashPartitioner #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Linary requested changes Apr 2, 2021
| int workerId = partitioner.workerId(partitionId); | ||
| workerStat[workerId]++; | ||
| } | ||
| LOG.info("partitionStat: {}", Arrays.toString(partitionStat)); |
There was a problem hiding this comment.
sum all partitionStat elem, it should be equal with 1024, then assert it.
Linary previously approved these changes Apr 2, 2021
javeme reviewed Apr 2, 2021
| | ||
| @Override | ||
| public int partitionId(Id vertexId) { | ||
| return Math.abs(vertexId.hashCode() % this.partitionCount); |
There was a problem hiding this comment.
hashCode = vertexId.hashCode() & 0x7fffffff
hashCode % this.partitionCount
| ComputerOptions.WORKER_PARTITIONER); | ||
| partitioner.init(config); | ||
| Id vertexId1 = new LongId(1L); | ||
| Id vertexId2 = new LongId(2L); |
There was a problem hiding this comment.
Id vertexId2 = new LongId(-1L);
Id vertexId2 = new LongId(-100L);
Id vertexId2 = new LongId(Long.MIN);
Id vertexId2 = new LongId(Long.MAX);
| workerStat[workerId]++; | ||
| } | ||
| LOG.info("partitionStat: {}", Arrays.toString(partitionStat)); | ||
| LOG.info("workerStat: {}", Arrays.toString(workerStat)); |
There was a problem hiding this comment.
improve log message
and add case:
- 1 worker 3 partition
- 1 worker 1 partition
- 3 worker 1 partition
javeme reviewed Apr 6, 2021
| ); | ||
| Config config = ComputerContext.instance().config(); | ||
| Partitioner partitioner = config.createObject( | ||
| ComputerOptions.WORKER_PARTITIONER); |
javeme reviewed Apr 6, 2021
| public static final ConfigOption<Class<?>> WORKER_PARTITIONER = | ||
| new ConfigOption<>( | ||
| "worker.partitioner", | ||
| "The partitioner that decides partition id by vertex id, " + |
| @Override | ||
| public void init(Config config) { | ||
| this.partitionCount = config.get(ComputerOptions.JOB_PARTITIONS_COUNT); | ||
| this.workerCount = config.get(ComputerOptions.JOB_WORKERS_COUNT); |
There was a problem hiding this comment.
Options required positiveInt()
| private int workerCount; | ||
| | ||
| public HashPartitioner() { | ||
| // pass |
javeme approved these changes Apr 6, 2021
Linary approved these changes Apr 7, 2021
coderzc pushed a commit that referenced this pull request Nov 9, 2021
Co-authored-by: Jermy Li <lizhangmei@baidu.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.