fix(k8s): modify inconsistent apiGroups #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| cc @coderzc |
| Hi @coderzc , CI meets |
Codecov Report
@@ Coverage Diff @@ ## master #270 +/- ## ========================================= Coverage 85.82% 85.83% - Complexity 3233 3234 +1 ========================================= Files 344 344 Lines 12124 12124 Branches 1092 1092 ========================================= + Hits 10406 10407 +1 - Misses 1193 1194 +1 + Partials 525 523 -2 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin approved these changes Oct 19, 2023
coderzc approved these changes Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
apiGroupsinClusterRoledefinition, which will cause the following permission error during launchinghugegraphcomputerjob-controller:io.fabric8.kubernetes.client.KubernetesClientException: Failure executing: GET at: https://10.96.0.1/apis/operator.hugegraph.apache.org/v1/hugegraphcomputerjobs. Message: Forbidden!Configured service account doesn't have access. Service account may have been revoked. hugegraphcomputerjobs.operator.hugegraph.apache.org is forbidden: User "system:serviceaccount:hugegraph-computer-operator-system:hugegraph-computer-operator-controller-manager" cannot list resource "hugegraphcomputerjobs" in API group "operator.hugegraph.apache.org" at the cluster scope.
Main Changes
KubeBuildercomment and generaterole.yamlwith correct apiGroups.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need