Skip to content

Conversation

Radeity
Copy link
Member

@Radeity Radeity commented Aug 28, 2023

Purpose of the PR

Main Changes

  • Remove CRD declaration in operator yaml.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
@Radeity
Copy link
Member Author

Radeity commented Aug 28, 2023

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #263 (49a256b) into master (510d7f9) will decrease coverage by 0.07%.
Report is 1 commits behind head on master.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #263 +/- ## ============================================ - Coverage 85.81% 85.75% -0.07%  + Complexity 3233 3232 -1  ============================================ Files 344 344 Lines 12115 12115 Branches 1092 1092 ============================================ - Hits 10397 10389 -8  - Misses 1193 1204 +11  + Partials 525 522 -3 
Files Changed Coverage Δ
...a/org/apache/hugegraph/computer/k8s/Constants.java 90.90% <ø> (ø)
...h/computer/k8s/crd/model/HugeGraphComputerJob.java 100.00% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@coderzc coderzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

@coderzc coderzc requested review from imbajin and simon824 August 28, 2023 03:50
@imbajin imbajin merged commit fdb4621 into apache:master Aug 28, 2023
@Radeity Radeity deleted the clean_operator_yaml branch August 28, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants