Skip to content

Conversation

conghuhu
Copy link
Contributor

@conghuhu conghuhu commented Jun 7, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • This change is a trivial rework / code cleanup without any test coverage.

(or)

  • This change is already covered by existing tests, such as (please describe tests).

(or)

  • This change added tests and can be verified as follows:

    (for example:)

    • Add UT.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - NO Need
@conghuhu
Copy link
Contributor Author

conghuhu commented Jun 7, 2023

@imbajin PTAL

imbajin
imbajin previously approved these changes Jun 7, 2023
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, could also add it in computer-doc

@imbajin imbajin changed the title docs: add note for missing classes docs: add building note for missing classes Jun 7, 2023
@imbajin imbajin changed the title docs: add building note for missing classes doc(k8s): add building note for missing classes Jun 7, 2023
@conghuhu
Copy link
Contributor Author

conghuhu commented Jun 7, 2023

computer-doc
Okay

@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #254 (5c68bb1) into master (7df3b43) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

@@ Coverage Diff @@ ## master #254 +/- ## ============================================ - Coverage 85.79% 85.78% -0.01%  + Complexity 3238 3233 -5  ============================================ Files 344 344 Lines 12105 12115 +10 Branches 1090 1092 +2 ============================================ + Hits 10385 10393 +8  - Misses 1194 1198 +4  + Partials 526 524 -2 
Impacted Files Coverage Δ
...graph/computer/core/sender/MessageSendBuffers.java 86.36% <33.33%> (-8.38%) ⬇️
...graph/computer/core/sender/MessageSendManager.java 78.40% <100.00%> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@imbajin imbajin merged commit fcc3b56 into apache:master Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants