- Notifications
You must be signed in to change notification settings - Fork 44
feat(core): isolate namespace for different input data source #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution.
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java Show resolved Hide resolved
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny comment
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java Outdated Show resolved Hide resolved
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java Outdated Show resolved Hide resolved
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java Show resolved Hide resolved
Codecov Report
@@ Coverage Diff @@ ## master #252 +/- ## ========================================= Coverage 85.79% 85.79% Complexity 3238 3238 ========================================= Files 344 344 Lines 12105 12111 +6 Branches 1090 1092 +2 ========================================= + Hits 10385 10391 +6 + Misses 1194 1192 -2 - Partials 526 528 +2
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
computer-api/src/main/java/org/apache/hugegraph/computer/core/config/ComputerOptions.java Outdated Show resolved Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
computer-core/src/main/java/org/apache/hugegraph/computer/core/bsp/BspBase.java Outdated Show resolved Hide resolved
Hi, @javeme , I drafted this PR yesterday, cuz maybe we don't have to add this If user submit a job with the same namespace and name, the existed job(resource) will be updated, for this, we should disable update operation to avoid interrupting running jobs. I'll create another issue to finish this work, WDYT? |
I think it's OK to disable the update operation. |
Get your point, do you mean in the scenario they share the same ETCD? |
Yes, one etcd for multi clusters. |
Purpose of the PR
Main Changes
JOB_NAMESPACE
, and modify ETCD namespace to{JOB_NAMESPACE}/{JOB_ID}
constructPath
which can be reused to construct a path generously.Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - NO Need