Skip to content

Conversation

msgui
Copy link
Contributor

@msgui msgui commented May 30, 2023

Purpose of the PR

  • update:readme

Main Changes

  • add QR code & email

Verifying these changes

This change is a trivial rework / code cleanup without any test coverage.

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - NO Need
@imbajin imbajin changed the title Update readme & add QR code doc: update readme & add QR code May 30, 2023
imbajin
imbajin previously approved these changes May 30, 2023
@imbajin
Copy link
Member

imbajin commented May 30, 2023

And it's better to use English in pic
image

consider edit/ps the pic (cut + add + override) it later

Co-authored-by: Cong Zhao <zhaocong@apache.org>
@msgui
Copy link
Contributor Author

msgui commented May 30, 2023

And it's better to use English in pic image

consider edit/ps the pic (cut + add + override) it later

Sure, I'll get it done!

@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #249 (dbbdb24) into master (7df3b43) will increase coverage by 0.09%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #249 +/- ## ============================================ + Coverage 85.79% 85.89% +0.09%  - Complexity 3238 3239 +1  ============================================ Files 344 344 Lines 12105 12105 Branches 1090 1090 ============================================ + Hits 10385 10397 +12  + Misses 1194 1182 -12  Partials 526 526 

see 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@msgui
Copy link
Contributor Author

msgui commented May 30, 2023

And it's better to use English in pic image

consider edit/ps the pic (cut + add + override) it later

hi @imbajin ,What do you think of the new pic?
new QR code

@Radeity
Copy link
Member

Radeity commented May 31, 2023

hi @imbajin ,What do you think of the new pic? new QR code

Hi, @msgui , humble suggestion, I think WeChat is better :D

@msgui
Copy link
Contributor Author

msgui commented May 31, 2023

Hi~ @Radeity ,Is the new pic what you expected? -> #256

@Radeity
Copy link
Member

Radeity commented May 31, 2023

Hi~ @Radeity ,Is the new pic what you expected? -> #255

Yes, thanks for you modification.

Radeity
Radeity previously approved these changes May 31, 2023
@coderzc coderzc merged commit e62ff3f into apache:master Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants