chore：change etcd url only for ci #245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
coderzc force-pushed the improve_use_k8s_etcd_test branch from f6a9f12 to 30c764a Compare coderzc force-pushed the improve_use_k8s_etcd_test branch from c103bcb to fd03ac5 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #245 +/- ## ============================================ + Coverage 85.83% 85.85% +0.02% Complexity 3232 3232 ============================================ Files 344 344 Lines 12072 12072 Branches 1087 1087 ============================================ + Hits 10362 10365 +3 + Misses 1185 1181 -4 - Partials 525 526 +1 see 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coderzc force-pushed the improve_use_k8s_etcd_test branch from fd03ac5 to 72d61b7 Compare 
imbajin reviewed May 24, 2023
computer-test/src/main/java/org/apache/hugegraph/computer/suite/unit/UnitTestBase.java Outdated Show resolved Hide resolved
imbajin previously approved these changes May 24, 2023
javeme reviewed May 24, 2023
| "ComputerOptions"); | ||
| OptionSpace.register("computer-rpc", | ||
| "org.apache.hugegraph.config.RpcOptions"); | ||
| OptionSpace.register("computer-rpc", "org.apache.hugegraph.config.RpcOptions"); |
There was a problem hiding this comment.
also update ComputerOptions
| } | ||
| | ||
| @AfterClass | ||
| public static void cleanup() { |
There was a problem hiding this comment.
move to line 150 to keep the customary order
javeme approved these changes May 24, 2023
imbajin approved these changes May 25, 2023
imbajin changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
Change etcd url only for ci, otherwise, we use the default address to local test
Main Changes
Change etcd url only for ci
Verifying these changes
(or)
(or)
This change added tests and can be verified as follows:
(for example:)
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - NO Need