fix: typo errors in start-computer.sh

[Radeity]

Fix some typo errors in start-computer.sh : )

Brief changes:

• (Spelling) Change muse to must.
• (Grammar) Add must before not be.

[codecov]

Codecov Report

Merging #238 (7fd3671) into master (cc5a7e7) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@ Coverage Diff @@ ## master #238 +/- ## ============================================ - Coverage 85.83% 85.73% -0.10%  + Complexity 3232 3228 -4  ============================================ Files 344 344 Lines 12072 12072 Branches 1087 1087 ============================================ - Hits 10362 10350 -12  - Misses 1185 1193 +8  - Partials 525 529 +4 

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Radeity]

Hi, @imbajin , thanks for your comment, i've already changed must not to can't, also make some other tiny typo changes, PTAL : )

[imbajin]

LGTM，and resolve the conversation is a right/good way during review 😁

[javeme]

LGTM

[imbajin]

The ci always failed (>10times)... any way to improve it? @coderzc

[Radeity]

The ci always failed (>10times)... any way to improve it? @coderzc

Hi, @imbajin, the error logs indicate that calling for jobObserver.onJobStateChanged() receive unexpected arg (status).

However, according to the UT codes, the only possible status change is from INITIALIZING to RUNNING, i'm a little confused, if the problem caused by unstable MiniKube environment, the probability of this happening is small, either.

BTW, I don't find the implementation class of JobObserver... I will be appreciated if you could guide me how to find it! Also, it seems that some classes are generated from go, such as org.apache.hugegraph.computer.k8s.crd.model.ComputerJobSpec, may i ask for the right way to map these go packages to java class? I really want to go on exploring our codes! cc @javeme @coderzc

[coderzc]

BTW, I don't find the implementation class of JobObserver... I will be appreciated if you could guide me how to find it!

The JobObserver will be implemented by calling KubernetesDriver.waitJobAsync

[Radeity]

The JobObserver will be implemented by calling KubernetesDriver.waitJobAsync

Get it, thanks!

[coderzc]

may i ask for the right way to map these go packages to java class? I really want to go on exploring our codes!

you can run https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s-operator/crd-generate/Makefile: gen-all , it will generate https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s-operator/manifest/hugegraph-computer-crd.v1.yaml and https://github.com/apache/incubator-hugegraph-computer/blob/master/computer-k8s/schema/crd-schema.json

[imbajin]

may i ask for the right way to map these go packages to java class? I really want to go on exploring our codes!

you can run master/computer-k8s-operator/crd-generate/Makefile: gen-all , it will generate master/computer-k8s-operator/manifest/hugegraph-computer-crd.v1.yaml and master/computer-k8s/schema/crd-schema.json

@Radeity we do lack the doc in computer, if u passed this problem , could add a doc PR to improve it (Actually the first time I ran it, was also confused 😿 )

[Radeity]

@Radeity we do lack the doc in computer, if u pass this problem , could add a doc PR to improve it (Actually the first time I run it, I'm also confused 😿 )

No problem, I'll try it later, I'm glad to help : )

[Radeity]

Hi, @imbajin , I find that make gen-all is needed only when someone want to develop and modify CRD or Controller, they have to generate and submit codes with newly generated yaml and json schema files.

Thus, for me, directly run mvn install can solve the problem, cuz java classes will be generated with existed json schema files and jsonschema2pojo plugin.

May i ask which type of doc do we need, a doc to describe code structures (the meaning of different modules) OR a doc to to tell how to build development environment?

[imbajin]

May i ask which type of doc do we need, a doc to describe code structures (the meaning of different modules) OR a doc to to tell how to build development environment?

We need add building-doc first for normal devs, then we could add the details u mentioned (optional & enhancement)

Hi, @imbajin , I find that make gen-all is needed only when someone want to develop and modify CRD or Controller, they have to generate and submit codes with newly generated yaml and json schema files.

Thus, for me, directly run mvn install can solve the problem, cuz java classes will be generated with existed json schema files and jsonschema2pojo plugin.

@coderzc could tell u the truth 👨🏻‍💻

[Radeity]

We need add building-doc first for normal devs, then we could add the details u mentioned (optional & enhancement)

Hi, @imbajin , thanks for your reply, I'll do it step by step as you mentioned.

@coderzc could tell u the truth 👨🏻‍💻

And I've already confirmed with him, thanks again for your help @coderzc :D