Change basic image to openjdk:11-slim #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
coderzc changed the title openjdk:11-slimopenjdk:11-slim 
Codecov Report
@@ Coverage Diff @@ ## master #216 +/- ## ========================================= Coverage 85.84% 85.84% Complexity 3233 3233 ========================================= Files 344 344 Lines 12079 12079 Branches 1087 1087 ========================================= Hits 10369 10369 Misses 1185 1185 Partials 525 525 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
imbajin reviewed Dec 5, 2022
| # limitations under the License. | ||
| # | ||
| FROM openjdk:11-jre | ||
| FROM openjdk:11-slim |
There was a problem hiding this comment.
could ensure the diff between slim and default (and comment in this PR for others to refer)
imbajin previously approved these changes Dec 5, 2022
javeme reviewed Dec 5, 2022
javeme approved these changes Dec 5, 2022
Error: Failures: Error: MiniKubeTest.testJobCancelled:258 Argument(s) are different! Wanted: jobObserver.onJobStateChanged( org.apache.hugegraph.computer.driver.DefaultJobState@525c5af0 ); -> at org.apache.hugegraph.computer.k8s.MiniKubeTest.testJobCancelled(MiniKubeTest.java:258) Actual invocations have different arguments: jobObserver.onJobStateChanged( org.apache.hugegraph.computer.driver.DefaultJobState@27687ac0 ); -> at org.apache.hugegraph.computer.k8s.driver.KubernetesDriver.waitJobAsync(KubernetesDriver.java:299) jobObserver.onJobStateChanged( org.apache.hugegraph.computer.driver.DefaultJobState@27687ac0 ); -> at org.apache.hugegraph.computer.k8s.driver.KubernetesDriver$1.eventReceived(KubernetesDriver.java:345) jobObserver.onJobStateChanged( org.apache.hugegraph.computer.driver.DefaultJobState@27687ac0 ); -> at org.apache.hugegraph.computer.k8s.driver.KubernetesDriver$1.eventReceived(KubernetesDriver.java:345) |
| ci error: 2022-12-06 07:11:45 (3.54 MB/s) - ‘ml-latest-small.zip’ saved [978202/978202] unzip -d ${DATASET_DIR} ml-latest-small.zip Archive: ml-latest-small.zip creating: computer-dist/src/assembly/travis/../dataset/ml-latest-small/ inflating: computer-dist/src/assembly/travis/../dataset/ml-latest-small/links.csv inflating: computer-dist/src/assembly/travis/../dataset/ml-latest-small/tags.csv inflating: computer-dist/src/assembly/travis/../dataset/ml-latest-small/ratings.csv inflating: computer-dist/src/assembly/travis/../dataset/ml-latest-small/README.txt inflating: computer-dist/src/assembly/travis/../dataset/ml-latest-small/movies.csv hugegraph-toolchain/hugegraph-loader/apache-hugegraph-loader-*/bin/hugegraph-loader.sh \ -g hugegraph -f ${DATASET_DIR}/struct.json -s ${DATASET_DIR}/schema.groovy || exit 1 computer-dist/src/assembly/travis/load-data-into-hugegraph.sh: line 39: hugegraph-toolchain/hugegraph-loader/apache-hugegraph-loader-incubating-1.0.0/bin/hugegraph-loader.sh: Permission denied Error: Process completed with exit code 1. |
imbajin reviewed Dec 7, 2022
| FROM openjdk:11-slim | ||
| LABEL maintainer="HugeGraph Docker Maintainers <dev@hugegraph.apache.org>" | ||
| WORKDIR /opt/app | ||
| WORKDIR /hugegraph/operator |
There was a problem hiding this comment.
current user is? is the access permission enough?
There was a problem hiding this comment.
rename to /opt/hugegraph-operator?
| shell script permission denied, @coderzc see |
imbajin approved these changes Dec 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.