Config add getBoolean, getInt, getLong, getDouble, getString #21
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #21 +/- ## ============================================ + Coverage 80.88% 81.08% +0.19% - Complexity 793 804 +11 ============================================ Files 79 79 Lines 2611 2638 +27 Branches 236 242 +6 ============================================ + Hits 2112 2139 +27 Misses 380 380 Partials 119 119
Continue to review full report at Codecov.
|
| return this.allConfig.get(option); | ||
| } | ||
| | ||
| public int getByte(String key, byte defaultValue) { |
There was a problem hiding this comment.
why not call get(TypedOption)
There was a problem hiding this comment.
The algorithm specific parameters are not in ComputerOptions.
houzhizhen changed the title | if (value == null) { | ||
| return defaultValue; | ||
| } else { | ||
| return Double.parseDouble(value); |
There was a problem hiding this comment.
check exception and throw more friendly exception
| return Integer.parseInt(value); | ||
| } catch (Exception e) { | ||
| throw new ComputerException( | ||
| "Can't parse '%s' into int for key '%s'", |
There was a problem hiding this comment.
Can't parse byte value from '%s' for key '%s'
| } | ||
| } | ||
| | ||
| public int getShort(String key, short defaultValue) { |
| if (value == null) { | ||
| return defaultValue; | ||
| } else { | ||
| return Boolean.parseBoolean(value); |
There was a problem hiding this comment.
no exception when parseBoolean, anything not "true" will regard it "false".
public static boolean parseBoolean(String s) {
return ((s != null) && s.equalsIgnoreCase("true"));
}
| return this.allConfig.get(option); | ||
| } | ||
| | ||
| public boolean getBoolean(String key, boolean defaultValue) { |
houzhizhen changed the title | "Can't parse boolean value from '%s' for key '%s'", | ||
| value, key); | ||
| } | ||
| |
| Config config = new Config(options); | ||
| Assert.assertEquals(value, config.getString(KEY, defaultValue)); | ||
| Assert.assertEquals(defaultValue, | ||
| config.getString(KEY_EMPTY, defaultValue)); |
There was a problem hiding this comment.
test pass defaultValue=null
4 participants
No description provided.