Skip to content

Conversation

coderzc
Copy link
Member

@coderzc coderzc commented Nov 26, 2022

  • Use IdSet instead of IdList to improve contains
  • Add addAll(Collection<Id> other) for IdSet
  • Make ClusteringCoefficient extends from TriangleCount
@coderzc coderzc added this to the 1.0.0 milestone Nov 26, 2022
@coderzc coderzc force-pushed the improve_trianglecount_cc branch 3 times, most recently from 0ddc2b3 to 4b1dd34 Compare November 26, 2022 08:08
@codecov
Copy link

codecov bot commented Nov 26, 2022

Codecov Report

Merging #201 (666a5ec) into master (adf6801) will decrease coverage by 0.01%.
The diff coverage is 96.00%.

@@ Coverage Diff @@ ## master #201 +/- ## ============================================ - Coverage 85.73% 85.71% -0.02%  + Complexity 3239 3230 -9  ============================================ Files 344 344 Lines 12111 12079 -32 Branches 1099 1087 -12 ============================================ - Hits 10383 10354 -29  Misses 1198 1198 + Partials 530 527 -3 
Impacted Files Coverage Δ
...hugegraph/computer/core/graph/value/ListValue.java 90.81% <ø> (-5.11%) ⬇️
...gorithm/community/trianglecount/TriangleCount.java 89.36% <83.33%> (-0.23%) ⬇️
.../algorithm/community/cc/ClusteringCoefficient.java 93.75% <100.00%> (+3.95%) ⬆️
...ithm/community/cc/ClusteringCoefficientOutput.java 100.00% <100.00%> (ø)
...rithm/community/cc/ClusteringCoefficientValue.java 83.33% <100.00%> (ø)
...hm/community/trianglecount/TriangleCountValue.java 100.00% <100.00%> (ø)
...idu/hugegraph/computer/core/graph/value/IdSet.java 77.77% <100.00%> (+10.13%) ⬆️
...mputer/k8s/operator/common/AbstractController.java 84.54% <0.00%> (-0.97%) ⬇️
...raph/computer/k8s/operator/OperatorEntrypoint.java 88.23% <0.00%> (+2.52%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@coderzc coderzc force-pushed the improve_trianglecount_cc branch from 4b1dd34 to 576be38 Compare November 26, 2022 08:26
@coderzc coderzc marked this pull request as draft November 26, 2022 08:47
@coderzc coderzc force-pushed the improve_trianglecount_cc branch 2 times, most recently from ba7937e to 28be030 Compare November 26, 2022 09:07
@coderzc coderzc force-pushed the improve_trianglecount_cc branch from 28be030 to 666a5ec Compare November 26, 2022 09:09
@coderzc coderzc marked this pull request as ready for review November 26, 2022 09:28
@coderzc coderzc requested a review from imbajin November 26, 2022 09:41
@corgiboygsj corgiboygsj merged commit 474f6ec into master Nov 26, 2022
@corgiboygsj corgiboygsj deleted the improve_trianglecount_cc branch November 26, 2022 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants