add transport interface #20
Conversation
| | ||
| import java.nio.ByteBuffer; | ||
| | ||
| public interface BufferHandler { |
| /** | ||
| * This method is called before a iteration. | ||
| */ | ||
| void startIteration(); |
There was a problem hiding this comment.
start() is ok, means start send
There was a problem hiding this comment.
start usually used to start a service, and called only once.
There was a problem hiding this comment.
startSession, finishSession
| /** | ||
| * Startup server, return the port listened. | ||
| */ | ||
| int setup(Config config, BufferHandler handler); |
There was a problem hiding this comment.
rename to listen(), don't return int
There was a problem hiding this comment.
A Transport4server need to listen on a port, there are multiple workers on a computer, need to listen on different port.
| public interface BufferHandler { | ||
| | ||
| /** | ||
| * Hand the buffer, it may block the caller a few seconds if it needs |
There was a problem hiding this comment.
It can leads to OOM if the speed of data process is slower than the speed of data received. There is no good async at both sender and receiver.
| * Startup server, return the port listened. | ||
| */ | ||
| int setup(Config config, BufferHandler handler); | ||
| |
There was a problem hiding this comment.
add pauseReceive() and resumeReceive()
if the pending_messages feature can control flow rate, we can delete ignore-resume
There was a problem hiding this comment.
listen, set the port range in config.
| * once. | ||
| * @throws IOException if can't create connection. | ||
| */ | ||
| void init(String hostname, int port) throws IOException; |
There was a problem hiding this comment.
Pass config as parameter, client set config MAX_PENDING_REQUESTS in conifg
| | ||
| public static final ConfigOption<Integer> WORKER_DATA_PORT_RANGE_START = | ||
| new ConfigOption<>( | ||
| "worker.data_port_range_start", |
| public static final ConfigOption<Integer> WORKER_DATA_PORT_RANGE_START = | ||
| new ConfigOption<>( | ||
| "worker.data_port_range_start", | ||
| "The start of range that the worker's data port listen on.", |
There was a problem hiding this comment.
improve description, listen port not listen port range.
also explain that we will choose one from small to large of the range
Codecov Report
@@ Coverage Diff @@ ## master #20 +/- ## ============================================ + Coverage 80.82% 80.86% +0.04% Complexity 790 790 ============================================ Files 79 79 Lines 2602 2608 +6 Branches 236 236 ============================================ + Hits 2103 2109 +6 Misses 380 380 Partials 119 119
Continue to review full report at Codecov.
|
| "worker.data_port_range_start", | ||
| "The start of range that the worker's data port listen on.", | ||
| "worker.data_port_start", | ||
| "The start of range [WORKER_DATA_PORT_START, " + |
There was a problem hiding this comment.
[data_port_start, data_port_end]
| "WORKER_DATA_PORT_END]. The worker will choose one from " + | ||
| "small to large of the range for data transportation.", | ||
| "The start of range [data_port_start, data_port_end]. " + | ||
| "The worker will choose one from small to large of the range" + |
| | ||
| /** | ||
| * Startup server, return the port listened. The port range in config is | ||
| * [{@link @ComputerOptions.WORKER_DATA_PORT_RANGE_START #STATIC_FIELD}, |
| | ||
| /** | ||
| * Init the connection from client to server. This method is called only | ||
| * once. MAX_PENDING_REQUESTS is set in config |
There was a problem hiding this comment.
remove redudant blank before 'is'
| void init(Config config, String hostname, int port) throws IOException; | ||
| | ||
| /** | ||
| * This method is called before a iteration of sending buffers. |
There was a problem hiding this comment.
before a iteration -> before an iteration
add lpa output (apache#20)
5 participants
No description provided.