[fix][ci] Fix loader compile error & adaptation apache loader/client #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| refer the latest toolchain CI code, the commit ID in server has passed >100 times.. so it alert this error. use the recent commit ID is fine
|
imbajin reviewed Nov 7, 2022
Comment on lines -84 to +86
| <groupId>com.baidu.hugegraph</groupId> | ||
| <groupId>org.apache.hugegraph</groupId> | ||
| <artifactId>hugegraph-client</artifactId> | ||
| <version>2.0.1</version> | ||
| <version>1.0.0</version> |
There was a problem hiding this comment.
no, we can't use it now (we could only use commons)
and we also should add a maven repo URL in setting.xml in CI if we want to use it
There was a problem hiding this comment.
we need install the client.jar in CI by ourselves
| another way to solve this problem is that we change the however, we need handle the latest version in the last :) |
14 tasks
coderzc changed the title coderzc force-pushed the fix_ci branch 2 times, most recently from 3820676 to ad06bed Compare coderzc force-pushed the fix_ci branch 2 times, most recently from 22e5190 to e3b0fc5 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #194 +/- ## ============================================ - Coverage 86.12% 86.11% -0.02% + Complexity 3212 3210 -2 ============================================ Files 341 341 Lines 12200 12197 -3 Branches 1085 1085 ============================================ - Hits 10507 10503 -4 + Misses 1171 1170 -1 - Partials 522 524 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
coderzc changed the title coderzc changed the title imbajin approved these changes Nov 22, 2022
javeme approved these changes Nov 22, 2022
| } | ||
| | ||
| @BeforeClass | ||
| public static void step() throws ClassNotFoundException { |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.