expand some operator function #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
javeme reviewed Jan 14, 2022
| crInformer.addEventHandler(new ResourceEventHandler<T>() { | ||
| @Override | ||
| public void onAdd(T cr) { | ||
| LOG.info("received a CR add request: {}", cr.getMetadata()); |
| } | ||
| OperatorResult result; | ||
| try { | ||
| LOG.debug("start reconcile request: {}", request); |
There was a problem hiding this comment.
expect the first letter capitalized
| | ||
| @Override | ||
| public void onUpdate(T oldCR, T cr) { | ||
| LOG.info("received a CR update request: {}", cr.getMetadata()); |
| | ||
| protected abstract OperatorResult reconcile(OperatorRequest request); | ||
| | ||
| protected abstract void handleFailOverLimit(OperatorRequest request, |
Codecov Report
@@ Coverage Diff @@ ## master #179 +/- ## ============================================ + Coverage 87.27% 87.36% +0.08% - Complexity 3137 3152 +15 ============================================ Files 332 332 Lines 11741 11806 +65 Branches 1038 1053 +15 ============================================ + Hits 10247 10314 +67 + Misses 994 988 -6 - Partials 500 504 +4
Continue to review full report at Codecov.
|
coderzc force-pushed the extend_operator branch from 6a8e4be to 51c76da Compare javeme reviewed Jan 14, 2022
| .getLog(true); | ||
| } catch (KubernetesClientException e) { | ||
| if (e.getCode() == HttpURLConnection.HTTP_NOT_FOUND) { | ||
| // Fix the pod deleted when job failed |
coderzc force-pushed the extend_operator branch 2 times, most recently from 260f05f to 2ff13d9 Compare 
* add fail over limit handler * pod topology spread constraints by node
coderzc force-pushed the extend_operator branch 2 times, most recently from 3e0822d to 46175c9 Compare coderzc force-pushed the extend_operator branch from 46175c9 to 16fc942 Compare 
add some tests to cover more codes? |
coderzc force-pushed the extend_operator branch from c70fd67 to eca0796 Compare coderzc force-pushed the extend_operator branch from eca0796 to da87d55 Compare javeme approved these changes Jan 29, 2022
imbajin approved these changes Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.