update java version to 11 #170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
coderzc force-pushed the update_jdk11 branch 7 times, most recently from a2ea0f1 to 826956e Compare 
Codecov Report
@@ Coverage Diff @@ ## master #170 +/- ## ============================================ - Coverage 87.34% 87.29% -0.06% - Complexity 3051 3136 +85 ============================================ Files 320 332 +12 Lines 11432 11741 +309 Branches 993 1038 +45 ============================================ + Hits 9985 10249 +264 - Misses 980 991 +11 - Partials 467 501 +34
Continue to review full report at Codecov.
|
coderzc force-pushed the update_jdk11 branch from 826956e to 58d6c95 Compare 
corgiboygsj previously approved these changes Dec 23, 2021
javeme previously approved these changes Dec 23, 2021
javeme reviewed Dec 24, 2021
| with: | ||
| java-version: '8' | ||
| distribution: 'adopt' | ||
| distribution: 'zulu' |
There was a problem hiding this comment.
need to also update to java-version: '11'?
There was a problem hiding this comment.
it is need to compile hugegraph-server
javeme reviewed Dec 24, 2021
| | ||
| if (cpu != null) { | ||
| EnvVar cpuLimit = new EnvVarBuilder() | ||
| .withName(Constants.ENV_CPU_LIMIT) |
| | ||
| if (memory != null) { | ||
| EnvVar memoryLimit = new EnvVarBuilder() | ||
| .withName(Constants.ENV_MEMORY_LIMIT) |
| # avoid `Runtime.getRuntime().availableProcessors()` always return 1 | ||
| if [ "${DRIVE}" = "${K8S_DRIVE}" && -z "${CPU_LIMIT}"]; then | ||
| CPU_COUNT="$(cat /proc/cpuinfo| grep "processor"| wc -l)" | ||
| JAVA="${JAVA} -XX:ActiveProcessorCount=${CPU_COUNT}" |
javeme reviewed Dec 24, 2021
| | ||
| if (cpu != null) { | ||
| EnvVar cpuLimit = new EnvVarBuilder() | ||
| .withName(Constants.ENV_CPU_LIMIT) |
coderzc force-pushed the update_jdk11 branch 5 times, most recently from 2bc6d2b to b8f3ffa Compare coderzc force-pushed the update_jdk11 branch from b8f3ffa to b1b471a Compare javeme reviewed Dec 28, 2021
computer-dist/Dockerfile Outdated
| FROM mcr.microsoft.com/java/jre:11-zulu-ubuntu | ||
| LABEL maintainer="HugeGraph Docker Maintainers <hugegraph@googlegroups.com>" | ||
| ENV JAVA_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -XX:MaxRAMFraction=2 -XshowSettings:vm" | ||
| ENV JAVA_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UseParallelGC -XX:+UseContainerSupport -XX:MaxRAMPercentage=80" |
There was a problem hiding this comment.
can we add some comments why to choose ParallelGC instead of ZGC?
coderzc force-pushed the update_jdk11 branch 3 times, most recently from ded9077 to b9ad7fe Compare javeme reviewed Jan 11, 2022
computer-core/src/main/java/com/baidu/hugegraph/computer/core/config/ComputerOptions.java Outdated Show resolved Hide resolved
| if [ ${CPU_COUNT} -gt ${MAX_CPU_COUNT} ]; then | ||
| CPU_COUNT="$MAX_CPU_COUNT" | ||
| PROCESSOR_COUNT="$(cat /proc/cpuinfo| grep "processor"| wc -l)" | ||
| let MAX_PROCESSOR_COUNT=8 |
There was a problem hiding this comment.
the cpu number can't be greater than 8?
There was a problem hiding this comment.
cpu number is too more will lead to huge number of GC thread
better not more than 8, if not specify cpu limit
javeme reviewed Jan 14, 2022
| let MAX_CPU_COUNT=8 | ||
| if [ ${CPU_COUNT} -gt ${MAX_CPU_COUNT} ]; then | ||
| CPU_COUNT="$MAX_CPU_COUNT" | ||
| PROCESSOR_COUNT="$(cat /proc/cpuinfo| grep "processor"| wc -l)" |
javeme reviewed Jan 17, 2022
computer-dist/Dockerfile Outdated
| FROM openjdk:11-jre | ||
| LABEL maintainer="HugeGraph Docker Maintainers <hugegraph@googlegroups.com>" | ||
| ENV JAVA_OPTS="-XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -XX:MaxRAMFraction=2 -XshowSettings:vm" | ||
| # use ParallelGC is more friendly to olap system |
There was a problem hiding this comment.
use ParallelGC which is more friendly to olap system
javeme approved these changes Jan 18, 2022
imbajin approved these changes Jan 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.