improve: refactor combiner #169
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
corgiboygsj force-pushed the improve-combiner branch from a1ece64 to 37e28c4 Compare 
javeme reviewed Dec 20, 2021
...ter-api/src/main/java/com/baidu/hugegraph/computer/core/combiner/DoubleValueSumCombiner.java Outdated Show resolved Hide resolved
...uter-api/src/main/java/com/baidu/hugegraph/computer/core/combiner/FloatValueSumCombiner.java Outdated Show resolved Hide resolved
computer-api/src/main/java/com/baidu/hugegraph/computer/core/combiner/IntValueSumCombiner.java Outdated Show resolved Hide resolved
computer-api/src/main/java/com/baidu/hugegraph/computer/core/combiner/LongValueSumCombiner.java Outdated Show resolved Hide resolved
...api/src/main/java/com/baidu/hugegraph/computer/core/combiner/MergeNewPropertiesCombiner.java Show resolved Hide resolved
...api/src/main/java/com/baidu/hugegraph/computer/core/combiner/MergeOldPropertiesCombiner.java Show resolved Hide resolved
...pi/src/main/java/com/baidu/hugegraph/computer/core/combiner/OverwritePropertiesCombiner.java Outdated Show resolved Hide resolved
.../src/main/java/com/baidu/hugegraph/computer/core/receiver/edge/EdgeMessageRecvPartition.java Outdated Show resolved Hide resolved
| Assert.assertEquals(properties2, properties); | ||
| } | ||
| //@Test | ||
| //public void testCombineVertex() { |
There was a problem hiding this comment.
yes, OverwriteCombiner only can combine Value now.
...uter-test/src/main/java/com/baidu/hugegraph/computer/core/sort/sorter/SortLargeDataTest.java Outdated Show resolved Hide resolved
corgiboygsj force-pushed the improve-combiner branch from bdf8e8d to c4ff2c1 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #169 +/- ## ============================================ - Coverage 87.36% 87.33% -0.03% - Complexity 3000 3057 +57 ============================================ Files 314 324 +10 Lines 11261 11465 +204 Branches 977 995 +18 ============================================ + Hits 9838 10013 +175 - Misses 960 980 +20 - Partials 463 472 +9
Continue to review full report at Codecov.
|
corgiboygsj force-pushed the improve-combiner branch from bd0f67e to 70ac440 Compare javeme reviewed Dec 23, 2021
| input1.seek(v1.offset()); | ||
| input2.seek(v2.offset()); | ||
| String label1 = StreamGraphInput.readLabel(input1); | ||
| String label2 = StreamGraphInput.readLabel(input2); |
There was a problem hiding this comment.
also move label to property class?
| writer.writeSubKv(out -> { | ||
| this.writeId(out, edge.targetId()); | ||
| }, out -> { | ||
| this.writeLabel(out, edge.label()); |
There was a problem hiding this comment.
seems to lose the label value?
javeme approved these changes Dec 24, 2021
coderzc approved these changes Dec 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.