add DefaultPropertiesCombiner and DefaultVertexValueCombiner #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
houzhizhen force-pushed the vertex-combiner branch from efd3688 to 99d0197 Compare 
Linary requested changes Mar 8, 2021
| * specifies how to combine their values. | ||
| */ | ||
| public class DefaultVertexValueCombiner<T extends Value> | ||
| implements VertexValueCombiner<T> { |
javeme requested changes Mar 8, 2021
| @RunWith(Suite.class) | ||
| @Suite.SuiteClasses({ | ||
| DefaultPropertiesCombinerTest.class, | ||
| DefaultVertexValueCombinerTest.class, |
There was a problem hiding this comment.
add OverwriteValueCombiner for any type.
and add MergeNewPropertiesCombiner and MergeOldPropertiesCombiner
Codecov Report
@@ Coverage Diff @@ ## master #16 +/- ## ============================================ + Coverage 77.33% 77.64% +0.30% - Complexity 621 634 +13 ============================================ Files 65 70 +5 Lines 2118 2138 +20 Branches 172 174 +2 ============================================ + Hits 1638 1660 +22 + Misses 372 371 -1 + Partials 108 107 -1
Continue to review full report at Codecov.
|
javeme requested changes Mar 9, 2021
| */ | ||
| public class DefaultVertexValueCombiner<T extends Value> | ||
| implements VertexValueCombiner<T> { | ||
| implements VertexValueCombiner<T> { |
There was a problem hiding this comment.
remove VertexValueCombiner class
| | ||
| import com.baidu.hugegraph.computer.core.graph.value.Value; | ||
| | ||
| public class OverwriteValueCombiner<T extends Value> |
| | ||
| @Test | ||
| public void test() { | ||
| Properties properties1 = new DefaultProperties(); |
There was a problem hiding this comment.
testOverwriteProperties() for OverwriteCombiner<Properties>
| public class OverwriteValueCombinerTest { | ||
| | ||
| @Test | ||
| public void test() { |
There was a problem hiding this comment.
add 3 tests:
testOverwriteValue()
testOverwriteVertex()
testOverwriteProperties()
houzhizhen force-pushed the vertex-combiner branch from f5cc502 to 2a76289 Compare javeme reviewed Mar 9, 2021
| DefaultVertexValueCombinerTest.class, | ||
| DoubleValueSumCombinerTest.class, | ||
| OverwriteValueCombinerTest.class, | ||
| OverwriteCombinerTest.class, |
| Vertex vertex2 = factory.createVertex(longId2, value2); | ||
| vertex2.addEdge(factory.createEdge(new LongId(1L), NullValue.get())); | ||
| | ||
| OverwriteCombiner<Vertex> combiner = new OverwriteCombiner(); |
| public class MergeNewPropertiesCombinerTest { | ||
| | ||
| @Test | ||
| public void test() { |
| * remain the value in v2. | ||
| */ | ||
| @Override | ||
| public Properties combine(Properties v1, Properties v2) { |
There was a problem hiding this comment.
check v1 and v2 not null, and add test case.
also improve Value*Combiner
| public class MergeOldPropertiesCombinerTest { | ||
| | ||
| @Test | ||
| public void test() { |
javeme reviewed Mar 10, 2021
| | ||
| @Override | ||
| public LongValue combine(LongValue v1, LongValue v2) { | ||
| E.checkArgumentNotNull(v1, "The parameter v1 can't be null"); |
There was a problem hiding this comment.
It's unified with others not null checks. If it fails, the stack trance will show the information.
javeme approved these changes Mar 10, 2021
coderzc approved these changes Mar 10, 2021
Linary approved these changes Mar 10, 2021
coderzc pushed a commit that referenced this pull request Nov 9, 2021
add a one time output example in pagerank-master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.