improve value interface #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #126 +/- ## ============================================ - Coverage 88.00% 87.98% -0.02% Complexity 2854 2854 ============================================ Files 300 300 Lines 10768 10787 +19 Branches 902 904 +2 ============================================ + Hits 9476 9491 +15 - Misses 864 867 +3 - Partials 428 429 +1
Continue to review full report at Codecov.
|
javeme reviewed Oct 22, 2021
| | ||
| @Override | ||
| public Object object() { | ||
| public Object value() { |
| | ||
| @Override | ||
| public Object object() { | ||
| public Object value() { |
There was a problem hiding this comment.
unify UnsupportedOperationException and NotSupportedException
| /** | ||
| * @return result string value of this object | ||
| */ | ||
| default String resultString() { |
javeme approved these changes Oct 22, 2021
imbajin approved these changes Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.