Implement closeness centrality algorithm #104

Linary · 2021-09-15T07:49:49Z

No description provided.

codecov · 2021-10-14T03:15:27Z

Codecov Report

Merging #104 (795697e) into master (77ea9aa) will decrease coverage by 0.15%.
The diff coverage is 78.30%.

@@ Coverage Diff @@ ## master #104 +/- ## ============================================ - Coverage 87.50% 87.35% -0.16%  - Complexity 2933 2988 +55  ============================================ Files 308 314 +6 Lines 10999 11195 +196 Branches 941 964 +23 ============================================ + Hits 9625 9779 +154  - Misses 929 957 +28  - Partials 445 459 +14

Impacted Files	Coverage Δ
...ugegraph/computer/core/graph/value/FloatValue.java	`96.87% <0.00%> (-3.13%)`	⬇️
...hugegraph/computer/core/graph/value/LongValue.java	`96.87% <0.00%> (-3.13%)`	⬇️
...idu/hugegraph/computer/core/graph/value/Value.java	`78.57% <0.00%> (-6.05%)`	⬇️
.../baidu/hugegraph/computer/core/util/CoderUtil.java	`57.14% <ø> (ø)`
...du/hugegraph/computer/core/worker/Computation.java	`100.00% <ø> (ø)`
...ugegraph/computer/core/config/ComputerOptions.java	`100.00% <ø> (ø)`
.../hugegraph/computer/core/io/StructGraphOutput.java	`85.29% <ø> (ø)`
...ugegraph/computer/k8s/driver/KubernetesDriver.java	`86.94% <ø> (ø)`
...algorithm/centrality/closeness/ClosenessValue.java	`14.28% <14.28%> (ø)`
...gegraph/computer/core/io/OptimizedBytesOutput.java	`98.80% <50.00%> (ø)`
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e081a0a...795697e. Read the comment docs.

...in/java/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentrality.java

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/BuiltinGraphFactory.java

...in/java/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentrality.java

javeme · 2021-10-14T15:58:45Z

...rc/main/java/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessValue.java

+ for (int i = 0; i < size; i++) {
+ Id id = this.graphFactory.createId();
+ id.read(in);
+ Value<?> value = this.graphFactory.createValue(ValueType.DOUBLE);
+ value.read(in);
+ this.map.put(id, (DoubleValue) value);
+ }


call map.read(in)?

this map is HashMap

let ClosenessValue extend MapValue, or just use MapValue class?

just use MapValue

...rc/main/java/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessValue.java

...om/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityLogOutput.java

...a/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityOutput.java

...main/java/com/baidu/hugegraph/computer/algorithm/centrality/degree/DegreeCentralityTest.java

computer-test/src/main/java/com/baidu/hugegraph/computer/suite/unit/UnitTestBase.java

coderzc · 2021-10-27T05:23:23Z

.../main/java/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessMessage.java

+ }
+
+ @Override
+ public Object object() {


rename to value

coderzc · 2021-10-28T11:33:45Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/sender/QueuedMessageSender.java

 * until any queue is available
 */
 if (emptyQueueCount >= channelCount) {
+ LOG.info("The send executor was blocked " +


use debug level

It will lead too many print info

will not lead too many print info?

coderzc · 2021-10-28T11:33:52Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/sender/QueuedMessageSender.java

 * until any client is available
 */
 if (busyClientCount >= channelCount) {
+ LOG.info("The send executor was blocked " +


It will lead too many print info

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/MapValue.java

computer-dist/Dockerfile

...a/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityOutput.java

javeme · 2021-10-29T04:00:34Z

...om/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityLogOutput.java

+ MapValue<DoubleValue> localValue = vertex.value();
+ // Cumulative distance
+ double centrality = 0;
+ for (Map.Entry<Id, DoubleValue> entry : localValue.entrySet()) {
+ centrality += 1.0D / entry.getValue().value();


move to MapValue.string()?

What mean? Move the for-loop logic into string() method?

I mean try to let ClosenessCentralityValue extends MapValue, move this block to ClosenessCentralityValue.value()/string(), and delete ClosenessCentralityLogOutput since LimitedLogOutput can log through ClosenessCentralityValue.string()

javeme · 2021-11-15T05:35:21Z

computer-core/src/main/java/com/baidu/hugegraph/computer/core/sender/QueuedMessageSender.java

 * until any queue is available
 */
 if (emptyQueueCount >= channelCount) {
+ LOG.info("The send executor was blocked " +


will not lead too many print info?

javeme · 2021-11-15T05:36:12Z

...ava/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityTest.java

+ .put("F", 1.45)
+ .build();
+
+ public Vertex constructHugeVertex(


override value() method instead

javeme · 2021-11-15T05:37:56Z

...ava/com/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityTest.java

+ .put("F", 3.333333333333333)
+ .build();
+
+ public Vertex constructHugeVertex(


...main/java/com/baidu/hugegraph/computer/algorithm/centrality/degree/DegreeCentralityTest.java

javeme · 2021-11-15T05:42:25Z

...om/baidu/hugegraph/computer/algorithm/centrality/closeness/ClosenessCentralityLogOutput.java

+ MapValue<DoubleValue> localValue = vertex.value();
+ // Cumulative distance
+ double centrality = 0;
+ for (Map.Entry<Id, DoubleValue> entry : localValue.entrySet()) {
+ centrality += 1.0D / entry.getValue().value();


I mean try to let ClosenessCentralityValue extends MapValue, move this block to ClosenessCentralityValue.value()/string(), and delete ClosenessCentralityLogOutput since LimitedLogOutput can log through ClosenessCentralityValue.string()

Linary force-pushed the closeness branch 5 times, most recently from a777aeb to c0beafd Compare September 28, 2021 06:37

Linary force-pushed the closeness branch from c0beafd to aa10781 Compare October 14, 2021 03:07

javeme reviewed Oct 14, 2021

View reviewed changes

Linary force-pushed the closeness branch from 9b9c21d to cd5f04d Compare October 15, 2021 02:28

javeme reviewed Oct 15, 2021

View reviewed changes

Linary force-pushed the closeness branch 2 times, most recently from 353e56a to e6be433 Compare October 15, 2021 06:46

javeme previously approved these changes Oct 15, 2021

View reviewed changes

coderzc requested changes Oct 27, 2021

View reviewed changes

coderzc requested changes Oct 28, 2021

View reviewed changes

Linary dismissed javeme’s stale review via 1f59a56 October 28, 2021 11:51

Linary force-pushed the closeness branch from e6be433 to 1f59a56 Compare October 28, 2021 11:51

coderzc requested changes Oct 28, 2021

View reviewed changes

computer-core/src/main/java/com/baidu/hugegraph/computer/core/graph/value/MapValue.java Outdated Show resolved Hide resolved

computer-dist/Dockerfile Show resolved Hide resolved

javeme reviewed Oct 29, 2021

View reviewed changes

Linary force-pushed the closeness branch from 1f59a56 to df632bb Compare November 15, 2021 03:31

javeme reviewed Nov 15, 2021

View reviewed changes

Linary added 4 commits December 13, 2021 11:11

Implement closeness centrality algorithm

403cae4

tiny improve

f83543e

rebase it

db4e2f6

rebase

94c08e1

Linary force-pushed the closeness branch 3 times, most recently from b712b05 to 92d9c53 Compare December 13, 2021 06:19

rebase and tiny improve

795697e

Linary force-pushed the closeness branch from 92d9c53 to 795697e Compare December 13, 2021 07:19

javeme approved these changes Dec 13, 2021

View reviewed changes

imbajin approved these changes Dec 13, 2021

View reviewed changes

javeme merged commit 0224cce into master Dec 13, 2021

javeme deleted the closeness branch December 13, 2021 15:07

Implement closeness centrality algorithm #104

Implement closeness centrality algorithm #104

Uh oh!

Conversation

Linary commented Sep 15, 2021

codecov bot commented Oct 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javeme Oct 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

javeme Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Uh oh!

javeme Nov 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Labels

4 participants

codecov bot commented Oct 14, 2021 •

edited

Loading

javeme Oct 15, 2021 •

edited

Loading

javeme Nov 15, 2021 •

edited

Loading

javeme Nov 15, 2021 •

edited

Loading