Skip to content

fix: fusiform_similarity test in traverser for server 1.3.0 #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix: fusiform_similarity test in traverser for server 1.3.0 #37

merged 2 commits into from
Apr 15, 2024

Conversation

@liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Apr 13, 2024 •
edited by imbajin
Loading

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels Apr 13, 2024
@liuxiaocs7 liuxiaocs7 changed the title fix: python client test fix: python client traverser test Apr 13, 2024
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Apr 13, 2024
@liuxiaocs7 liuxiaocs7 changed the title fix: python client traverser test fix: fusiform_similarity test in traverser Apr 13, 2024
@liuxiaocs7
Copy link
Member Author

liuxiaocs7 commented Apr 14, 2024

Note: here requires Python 3.9+:

incubator-hugegraph-ai/hugegraph-python-client/setup.py

Line 44 in 4f48116

python_requires=">=3.9",

In doc requires Python 3.8+: https://hugegraph.apache.org/docs/quickstart/hugegraph-ai/

Seems like it needs to be unified?
@simon824
Copy link
Member

simon824 commented Apr 15, 2024

refer to https://github.com/apache/incubator-hugegraph/pull/2458/files
simon824
simon824 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
imbajin
imbajin approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already update the title & comment in apache/incubator-hugegraph#2458 (comment)
@imbajin imbajin merged commit 243f547 into apache:main Apr 15, 2024
@imbajin imbajin changed the title fix: fusiform_similarity test in traverser fix: fusiform_similarity test in traverser for server 1.3.0 Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.

3 participants

@liuxiaocs7 @simon824 @imbajin