Skip to content

fix: base-ref/head-ref missed in dependency-check-ci on branch push #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2023
Merged

fix: base-ref/head-ref missed in dependency-check-ci on branch push #25

merged 1 commit into from
Oct 25, 2023

Conversation

@liuxiaocs7
Copy link
Member

@liuxiaocs7 liuxiaocs7 commented Oct 23, 2023 •
edited by simon824
Loading

simon824
simon824 approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@simon824 simon824 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
simon824
simon824 reviewed Oct 24, 2023
View reviewed changes
.github/workflows/check-dependencies.yml
push:
branches:
- main
- 'release-*'
Copy link
Member

@simon824 simon824 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep consistent with the hugegraph?
https://github.com/apache/incubator-hugegraph/blob/d4b95ca32371dfdee60d448fa3e5ab38fc4e288e/.github/workflows/check-dependencies.yml#L6
Copy link
Member Author

@liuxiaocs7 liuxiaocs7 Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i'll take a look, just ref: apache/incubator-hugegraph-toolchain#516 before.
Copy link
Member

@imbajin imbajin Oct 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, i'll take a look, just ref: apache/incubator-hugegraph-toolchain#516 before.

The reason is the running ci context is a little different, we need Check License Header in push action but don't need with Dependency Review, so consider:

  1. just remove push action like this
  2. separate them for different trigger logic (may need check the action doc) OR just divide into 2 CI files
@simon824 simon824 merged commit 08ed8d7 into apache:main Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@liuxiaocs7 @imbajin @simon824