fix(tests): resolve flaky catalog tests by waiting for S3 bucket creation #1599
+46 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…tion Fixes apache#1581 The glue-catalog-test and hms-catalog-test were failing intermittently with 'NoSuchBucket' errors due to a race condition where tests started before the MinIO 'warehouse' bucket was fully created. Changes: - Wait for both catalog service and MinIO service to be ready - Verify S3 bucket existence before proceeding with tests - Refactor to eliminate duplicate S3 properties configuration - Add proper retry logic with clear logging for bucket readiness This ensures tests only run after the complete test environment is properly initialized, eliminating the timing-based failures.
liurenjie1024 approved these changes Aug 14, 2025
Contributor
liurenjie1024 left a comment
liurenjie1024 left a comment There was a problem hiding this comment.
Thanks @fvaleye for this fix!
lliangyu-lin pushed a commit to lliangyu-lin/iceberg-rust that referenced this pull request Aug 21, 2025
…tion (apache#1599) ## Which issue does this PR close? - Closes apache#1581 ## What changes are included in this PR? This ensures tests only run after the complete test environment is initialized correctly, eliminating the timing-based failures. - Wait for both the catalog service and the MinIO service to be ready - Verify S3 bucket existence before proceeding with tests - Add proper retry logic with clear logging for bucket readiness ## Are these changes tested? Yes Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
Yiyang-C pushed a commit to Yiyang-C/iceberg-rust that referenced this pull request Aug 26, 2025
…tion (apache#1599) ## Which issue does this PR close? - Closes apache#1581 ## What changes are included in this PR? This ensures tests only run after the complete test environment is initialized correctly, eliminating the timing-based failures. - Wait for both the catalog service and the MinIO service to be ready - Verify S3 bucket existence before proceeding with tests - Add proper retry logic with clear logging for bucket readiness ## Are these changes tested? Yes Co-authored-by: Renjie Liu <liurenjie2008@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
What changes are included in this PR?
This ensures tests only run after the complete test environment is initialized correctly, eliminating the timing-based failures.
Are these changes tested?
Yes