HDFS-12431. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-hdfs Part6. #7739
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| 💔 -1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
zhtttylz force-pushed the hadoop-hdfs-part6 branch from 21ab637 to 6898a70 Compare | 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
| 🎊 +1 overall
This message was automatically generated. |
slfan1989 reviewed Jun 18, 2025
| import static org.apache.hadoop.hdfs.server.common.HdfsServerConstants.NodeType.DATA_NODE; | ||
| import static org.apache.hadoop.hdfs.server.common.HdfsServerConstants.NodeType.NAME_NODE; | ||
| import static org.junit.Assert.*; | ||
| import static org.junit.jupiter.api.Assertions.*; |
slfan1989 reviewed Jun 18, 2025
| import static org.hamcrest.CoreMatchers.not; | ||
| import static org.junit.Assert.*; | ||
| import static org.hamcrest.core.StringContains.containsString; | ||
| import static org.junit.jupiter.api.Assertions.*; |
Contributor Author
There was a problem hiding this comment.
Thanks for the feedback! I’ll update the code soon.
| 🎊 +1 overall
This message was automatically generated. |
slfan1989 reviewed Jun 19, 2025
| "same", | ||
| expected[startOffset + i], buf[i]); | ||
| Assertions.assertEquals(expected[startOffset + i], buf[i], | ||
| "Byte at " + (startOffset + i) + " should be the " + "same"); |
Contributor
There was a problem hiding this comment.
It’s better to use static imports to avoid situations like Assertions.*.
slfan1989 reviewed Jun 19, 2025
| @Test(expected=IOException.class) | ||
| @Test | ||
| public void testUpgradeFromPreUpgradeLVFails() throws IOException { | ||
| Assertions.assertThrows(IOException.class, () -> { |
Contributor
There was a problem hiding this comment.
It’s better to use static imports to avoid situations like Assertions.*.
slfan1989 reviewed Jun 19, 2025
| "localhost:9001"); | ||
| DFSUtil.getNamenodeNameServiceId(conf); | ||
| fail("Expected exception is not thrown"); | ||
| Assertions.assertThrows(HadoopIllegalArgumentException.class, () -> { |
Contributor
There was a problem hiding this comment.
avoid Assertions.assertThrows
slfan1989 reviewed Jun 19, 2025
| Assert.assertNotNull(conf); | ||
| Assert.assertNotNull(fs); | ||
| Assert.assertEquals(0, ToolRunner.run(conf, | ||
| Assertions.assertNotNull(conf); |
Contributor Author
There was a problem hiding this comment.
Thanks for the feedback—I'll update the code shortly.
| 🎊 +1 overall
This message was automatically generated. |
zhtttylz force-pushed the hadoop-hdfs-part6 branch from 24e1822 to 03b991e Compare | 💔 -1 overall
This message was automatically generated. |
slfan1989 approved these changes Jun 22, 2025
| 🎊 +1 overall
This message was automatically generated. |
Contributor
| @zhtttylz Thanks for the contribution! Merged into trunk. |
Contributor Author
| @slfan1989 for reviewing and merging! The remaining parts will be submitted soon. |
75 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA:HDFS-12431. Upgrade JUnit from 4 to 5 in hadoop-hdfs Part6.
How was this patch tested?
Junit Test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?