You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
zhtttylz changed the title HADOOP-19417. [Addendum] [JDK17] Upgrade JUnit from 4 to 5 in hadoop-… HADOOP-19417. [Addendum] [JDK17] Upgrade JUnit from 4 to 5 in hadoop-minikdc. Apr 30, 2025
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
23m 33s
trunk passed
+1 💚
compile
9m 7s
trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
compile
8m 20s
trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
mvnsite
0m 25s
trunk passed
+1 💚
javadoc
0m 26s
trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javadoc
0m 22s
trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
shadedclient
63m 16s
branch has no errors when building and testing our client artifacts.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
40m 51s
trunk passed
+1 💚
compile
17m 41s
trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
compile
15m 0s
trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
mvnsite
0m 41s
trunk passed
+1 💚
javadoc
0m 44s
trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javadoc
0m 37s
trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
shadedclient
114m 47s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
0m 17s
the patch passed
+1 💚
compile
16m 47s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javac
16m 47s
the patch passed
+1 💚
compile
14m 57s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
javac
14m 57s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
mvnsite
0m 38s
the patch passed
+1 💚
javadoc
0m 40s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javadoc
0m 38s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
shadedclient
43m 3s
patch has no errors when building and testing our client artifacts.
@zhtttylz Thanks for the contribution. We are currently actively improving the JUnit tests for Hadoop HDFS and Hadoop Common. We found that when the JUnit dependency for hadoop-minikdc is set to compile, it triggers a full compilation of all unit tests in the Hadoop HDFS module each time. Therefore, we plan to change the JUnit dependency for hadoop-minikdc to provided to optimize the compilation process. If the compilation of hadoop-common and hadoop-hdfs is completed, we will roll back this PR.
The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
_ trunk Compile Tests _
+1 💚
mvninstall
22m 58s
trunk passed
+1 💚
compile
8m 17s
trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
compile
7m 22s
trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
mvnsite
0m 27s
trunk passed
+1 💚
javadoc
0m 31s
trunk passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javadoc
0m 21s
trunk passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
shadedclient
60m 20s
branch has no errors when building and testing our client artifacts.
_ Patch Compile Tests _
+1 💚
mvninstall
0m 11s
the patch passed
+1 💚
compile
7m 51s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javac
7m 51s
the patch passed
+1 💚
compile
7m 27s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
javac
7m 27s
the patch passed
+1 💚
blanks
0m 0s
The patch has no blanks issues.
+1 💚
mvnsite
0m 25s
the patch passed
+1 💚
javadoc
0m 28s
the patch passed with JDK Ubuntu-11.0.26+4-post-Ubuntu-1ubuntu120.04
+1 💚
javadoc
0m 26s
the patch passed with JDK Private Build-1.8.0_442-8u442-b06us1-0ubuntu120.04-b06
+1 💚
shadedclient
23m 4s
patch has no errors when building and testing our client artifacts.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
JIRA: HADOOP-19417. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-minikdc.
How was this patch tested?
mvn clean test & junit test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?