- Notifications
You must be signed in to change notification settings - Fork 9.2k
HADOOP-19439. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-rumen. #7552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 💔 -1 overall
This message was automatically generated. |
zhtttylz left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1,LGTM @slfan1989
cnauroth left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1. Pre-submit flagged a problem with trailing whitespace. Can you please use git apply --whitespace=fix when you commit this? Thank you, @slfan1989 . @zhtttylz , thank you for reviewing.
| 🎊 +1 overall
This message was automatically generated. |
…che#7552) * HADOOP-19439. Upgrade JUnit from 4 to 5 in hadoop-rumen. Co-authored-by: Chris Nauroth <cnauroth@apache.org> Co-authored-by: Hualong Zhang <hualong.z@hotmail.com> Reviewed-by: Chris Nauroth <cnauroth@apache.org> Reviewed-by: Hualong Zhang <hualong.z@hotmail.com> Signed-off-by: Shilun Fan <slfan1989@apache.org>
Description of PR
JIRA: HADOOP-19439. [JDK17] Upgrade JUnit from 4 to 5 in hadoop-rumen.
How was this patch tested?
mvn clean test & junit test.
For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles?