YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice #4775

hotcodemacha · 2022-08-20T20:51:40Z

Description of PR

Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice

JIRA - YARN-11260

For code changes:

Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'HADOOP-17799. Your PR title ...')?
Object storage: have the integration tests been executed and the endpoint declared according to the connector-specific documentation?
If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
If applicable, have you updated the LICENSE, LICENSE-binary, NOTICE-binary files?

…ervice

hotcodemacha · 2022-08-20T22:37:31Z

Check style issues showing are old ones and not due to this PR

hotcodemacha · 2022-08-30T08:17:29Z

@aajisaka - Please help in reviewing the PR. Thanks.

hadoop-yetus · 2022-09-02T05:08:20Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	18m 36s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 1s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 17 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	42m 0s		trunk passed
+1 💚	compile	0m 37s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 33s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 34s		trunk passed
+1 💚	mvnsite	0m 38s		trunk passed
+1 💚	javadoc	0m 42s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 32s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 6s		trunk passed
+1 💚	shadedclient	23m 24s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 24s		the patch passed
+1 💚	compile	0m 26s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 26s		the patch passed
+1 💚	compile	0m 24s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 24s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
-0 ⚠️	checkstyle	0m 17s	/results-checkstyle-hadoop-yarn-project_hadoop-yarn_hadoop-yarn-server_hadoop-yarn-server-timelineservice.txt	hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice: The patch generated 1 new + 5 unchanged - 1 fixed = 6 total (was 6)
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 22s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 53s		the patch passed
+1 💚	shadedclient	23m 52s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 43s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	asflicense	0m 40s		The patch does not generate ASF License warnings.
		120m 28s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4775/2/artifact/out/Dockerfile
GITHUB PR	#4775
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux bc1cb22159ef 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `d2316b4`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4775/2/testReport/
Max. process+thread count	528 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4775/2/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

hotcodemacha · 2022-09-07T22:20:57Z

@aajisaka - Please help in reviewing the PR. Thanks.

hotcodemacha · 2022-10-01T17:51:25Z

@aajisaka - Please help in reviewing the PR. Thanks.

aajisaka

Thank you @ashutoshcipher for your contribution. Would you reflect my comments?

...org/apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesUtils.java

.../apache/hadoop/yarn/server/timelineservice/reader/TestTimelineReaderWebServicesBasicAcl.java

.../org/apache/hadoop/yarn/server/timelineservice/storage/TestFileSystemTimelineWriterImpl.java

hotcodemacha · 2022-10-06T14:54:24Z

Thanks @aajisaka for review. I will address you comments in my next commit.

hadoop-yetus · 2022-10-07T00:52:41Z

🎊 +1 overall

Vote	Subsystem	Runtime	Logfile	Comment
+0 🆗	reexec	0m 54s		Docker mode activated.
			_ Prechecks _
+1 💚	dupname	0m 0s		No case conflicting files found.
+0 🆗	codespell	0m 0s		codespell was not available.
+0 🆗	detsecrets	0m 0s		detect-secrets was not available.
+0 🆗	xmllint	0m 0s		xmllint was not available.
+1 💚	@author	0m 0s		The patch does not contain any @author tags.
+1 💚	test4tests	0m 0s		The patch appears to include 17 new or modified test files.
			_ trunk Compile Tests _
+1 💚	mvninstall	41m 26s		trunk passed
+1 💚	compile	0m 35s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	compile	0m 33s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	checkstyle	0m 35s		trunk passed
+1 💚	mvnsite	0m 39s		trunk passed
+1 💚	javadoc	0m 42s		trunk passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 31s		trunk passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	1m 6s		trunk passed
+1 💚	shadedclient	23m 40s		branch has no errors when building and testing our client artifacts.
			_ Patch Compile Tests _
+1 💚	mvninstall	0m 31s		the patch passed
+1 💚	compile	0m 25s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javac	0m 25s		the patch passed
+1 💚	compile	0m 23s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	javac	0m 23s		the patch passed
+1 💚	blanks	0m 0s		The patch has no blanks issues.
+1 💚	checkstyle	0m 19s		hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice: The patch generated 0 new + 5 unchanged - 1 fixed = 5 total (was 6)
+1 💚	mvnsite	0m 25s		the patch passed
+1 💚	javadoc	0m 23s		the patch passed with JDK Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04
+1 💚	javadoc	0m 22s		the patch passed with JDK Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
+1 💚	spotbugs	0m 53s		the patch passed
+1 💚	shadedclient	23m 17s		patch has no errors when building and testing our client artifacts.
			_ Other Tests _
+1 💚	unit	1m 43s		hadoop-yarn-server-timelineservice in the patch passed.
+1 💚	asflicense	0m 39s		The patch does not generate ASF License warnings.
		101m 56s

Subsystem	Report/Notes
Docker	ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4775/3/artifact/out/Dockerfile
GITHUB PR	#4775
Optional Tests	dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient codespell detsecrets xmllint spotbugs checkstyle
uname	Linux ca506af90d40 4.15.0-191-generic #202-Ubuntu SMP Thu Aug 4 01:49:29 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `bcbf519`
Default Java	Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Multi-JDK versions	/usr/lib/jvm/java-11-openjdk-amd64:Ubuntu-11.0.16+8-post-Ubuntu-0ubuntu120.04 /usr/lib/jvm/java-8-openjdk-amd64:Private Build-1.8.0_342-8u342-b07-0ubuntu1~20.04-b07
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4775/3/testReport/
Max. process+thread count	531 (vs. ulimit of 5500)
modules	C: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice U: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-4775/3/console
versions	git=2.25.1 maven=3.6.3 spotbugs=4.2.2
Powered by	Apache Yetus 0.14.0 https://yetus.apache.org

This message was automatically generated.

aajisaka

+1, thanks

hotcodemacha · 2022-10-09T15:36:05Z

Thank you so much @aajisaka for reviewing and merging.

…ervice (apache#4775) Co-authored-by: Ashutosh Gupta <ashugpt@amazon.com> Signed-off-by: Akira Ajisaka <aajisaka@apache.org>

YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelines…

26d86ed

…ervice

This comment was marked as outdated.

Sign in to view

Added junit-platform-launcher

d2316b4

aajisaka requested changes Oct 6, 2022

View reviewed changes

Addressed comments

bcbf519

aajisaka approved these changes Oct 8, 2022

View reviewed changes

aajisaka merged commit 9a7d0e7 into apache:trunk Oct 9, 2022

hotcodemacha deleted the YARN-11260 branch October 9, 2022 15:36

slfan1989 mentioned this pull request Jan 30, 2025

[DISCUSS] [JDK17] Upgrade JUnit / JavaDoc from 4 to 5. #7337

Draft

75 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice #4775

YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice #4775

Uh oh!

hotcodemacha commented Aug 20, 2022

This comment was marked as outdated.

hotcodemacha commented Aug 20, 2022

hotcodemacha commented Aug 30, 2022

hadoop-yetus commented Sep 2, 2022

hotcodemacha commented Sep 7, 2022

hotcodemacha commented Oct 1, 2022

aajisaka left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hotcodemacha commented Oct 6, 2022

hadoop-yetus commented Oct 7, 2022

aajisaka left a comment

hotcodemacha commented Oct 9, 2022

Labels

3 participants

YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice #4775

YARN-11260. Upgrade JUnit from 4 to 5 in hadoop-yarn-server-timelineservice #4775

Uh oh!

Conversation

hotcodemacha commented Aug 20, 2022

Description of PR

For code changes:

This comment was marked as outdated.

hotcodemacha commented Aug 20, 2022

hotcodemacha commented Aug 30, 2022

hadoop-yetus commented Sep 2, 2022

hotcodemacha commented Sep 7, 2022

hotcodemacha commented Oct 1, 2022

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hotcodemacha commented Oct 6, 2022

hadoop-yetus commented Oct 7, 2022

aajisaka left a comment

Choose a reason for hiding this comment

hotcodemacha commented Oct 9, 2022

Labels

3 participants