Skip to content

Conversation

@pandaapo
Copy link
Member

@pandaapo pandaapo commented Jul 2, 2023

Fixes #4174.

Motivation

Support to subscribe tcp message by tags when using RocketMQ storage plugin.

Modifications

Add api based on RocketMQ message tag related api to implement subscribing tcp message by tags when using RocketMQ storage plugin.

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
@codecov
Copy link

codecov bot commented Jul 3, 2023

Codecov Report

Attention: 80 lines in your changes are missing coverage. Please review.

Comparison is base (378aa75) 17.62% compared to head (6152f52) 17.59%.

Files Patch % Lines
...ache/eventmesh/client/tcp/common/MessageUtils.java 11.76% 15 Missing ⚠️
...nt/tcp/impl/cloudevent/CloudEventTCPSubClient.java 0.00% 12 Missing ⚠️
...eventmeshmessage/EventMeshMessageTCPSubClient.java 0.00% 12 Missing ⚠️
...he/eventmesh/common/protocol/SubscriptionItem.java 0.00% 11 Missing ⚠️
.../protocol/tcp/client/group/ClientGroupWrapper.java 0.00% 6 Missing ⚠️
...ntmesh/storage/rocketmq/producer/ProducerImpl.java 45.45% 5 Missing and 1 partial ⚠️
...pache/eventmesh/client/tcp/EventMeshTCPClient.java 0.00% 4 Missing ⚠️
...he/eventmesh/client/tcp/EventMeshTCPSubClient.java 0.00% 4 Missing ⚠️
...pl/eventmeshmessage/EventMeshMessageTCPClient.java 0.00% 4 Missing ⚠️
...entmesh/runtime/core/plugin/MQConsumerWrapper.java 0.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@ Coverage Diff @@ ## master #4175 +/- ## ============================================ - Coverage 17.62% 17.59% -0.03%  - Complexity 1784 1785 +1  ============================================ Files 805 807 +2 Lines 29924 29985 +61 Branches 2580 2584 +4 ============================================ + Hits 5273 5276 +3  - Misses 24169 24227 +58  Partials 482 482 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Alonexc
Alonexc previously approved these changes Jul 5, 2023
Pil0tXia and others added 28 commits July 27, 2023 23:52
…tBuilder . (apache#4285) * fix: Some code optimizations to the EventMeshCloudEventBuilder * [ISSUE apache#4261]: Fix get the corresponding IDC, not the ENV * refactor: rename private method 'builderCloudEvent' to 'buildCloudEvent' * refactor: rename private method * style: to fit `CheckStyle` plugin
* optimal http header converts * fix test error * fix
…eadUtils] (apache#4297) * Update ThreadUtils.java * Update ThreadUtils.java
…ectors] (apache#4314) * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in open function sinc connector * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in open function source connector * [ISSUE apache#4266]: Retore interrupted state for interrupted exception in RocketMQSink connector
…pache#4315) * [ISSUE apache#4093]: Refactor package building chunks to reusable method * [ISSUE apache#4093]: Refactor user agent building chunks to reusable method
…aced with lambda[HelloTask] (apache#4316) * [4260] Fixed: Anonymous new ChannelFutureListener() can be replaced with lambda[HelloTask] * Upgraded: First Interaction Action Version to Latest * [4260] Removed: Unused Import * Update package import order in HelloTask.java --------- Co-authored-by: mike_xwm <mike_xwm@126.com>
* fix: add cloudEventCodec for redis connector. * fix: add cloudEventCodec for redis connector. * fix import order. * fix: add doc. * fix: adjust cloudevent encode and decode.
@codecov-commenter
Copy link

codecov-commenter commented Apr 10, 2024

Codecov Report

❌ Patch coverage is 39.89326% with 901 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.59%. Comparing base (bae1307) to head (6152f52).
⚠️ Report is 4691 commits behind head on master.

Files with missing lines Patch % Lines
...mesh/connector/jdbc/connection/JdbcConnection.java 0.00% 137 Missing ⚠️
...nnector/file/sink/connector/FileSinkConnector.java 0.00% 62 Missing ⚠️
...g/apache/eventmesh/common/utils/JsonPathUtils.java 0.00% 54 Missing ⚠️
...ava/org/apache/eventmesh/common/utils/LogUtil.java 7.54% 48 Missing and 1 partial ⚠️
...tor/jdbc/connection/mysql/MysqlJdbcConnection.java 0.00% 43 Missing ⚠️
...dingtalk/sink/connector/DingDingSinkConnector.java 65.38% 24 Missing and 3 partials ⚠️
...pache/eventmesh/connector/jdbc/CatalogChanges.java 0.00% 25 Missing ⚠️
...ava/org/apache/eventmesh/connector/jdbc/Field.java 0.00% 24 Missing ⚠️
...ava/org/apache/eventmesh/common/ThreadWrapper.java 59.64% 16 Missing and 7 partials ⚠️
...g/apache/eventmesh/connector/jdbc/DataChanges.java 0.00% 22 Missing ⚠️
... and 88 more
Additional details and impacted files
@@ Coverage Diff @@ ## master #4175 +/- ## ============================================ + Coverage 16.92% 17.59% +0.66%  - Complexity 1412 1785 +373  ============================================ Files 589 807 +218 Lines 25789 29985 +4196 Branches 2397 2584 +187 ============================================ + Hits 4366 5276 +910  - Misses 20986 24227 +3241  - Partials 437 482 +45 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@Pil0tXia
Copy link
Member

It seems that this PR could have been merged.

@github-actions github-actions bot removed the Stale label Apr 11, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 10, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Aug 11, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Oct 11, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Dec 11, 2024
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Apr 14, 2025
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Jun 14, 2025
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added Stale and removed Stale labels Aug 14, 2025
@github-actions
Copy link
Contributor

It has been 60 days since the last activity on this pull request. I am reaching out here to gently remind you that the Apache EventMesh community values every pull request, and please feel free to get in touch with the reviewers at any time. They are available to assist you in advancing the progress of your pull request and offering the latest feedback.

If you encounter any challenges during development, seeking support within the community is encouraged. We sincerely appreciate your contributions to Apache EventMesh.

@github-actions github-actions bot added the Stale label Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment