Skip to content

Conversation

@PickBas
Copy link
Contributor

@PickBas PickBas commented May 13, 2023

Fixes #3909.

Modifications

Replaced anonymous new ChannelFutureListener() with lambda.

Documentation

  • Does this pull request introduce a new feature? (no)
@Alonexc
Copy link
Contributor

Alonexc commented May 15, 2023

please check the checkstyle.

@PickBas
Copy link
Contributor Author

PickBas commented May 15, 2023

@Alonexc Fixed, have a look please

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Merging #3923 (639b569) into master (1798e1f) will increase coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head 639b569 differs from pull request most recent head a16811b. Consider uploading reports for the commit a16811b to get more accurate results

@@ Coverage Diff @@ ## master #3923 +/- ## ========================================= Coverage 14.24% 14.24% Complexity 1320 1320 ========================================= Files 579 579 Lines 28958 28956 -2 Branches 2815 2815 ========================================= Hits 4125 4125 + Misses 24441 24439 -2  Partials 392 392 
Impacted Files Coverage Δ
.../protocol/tcp/client/task/MessageTransferTask.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Alonexc
Alonexc previously approved these changes May 17, 2023
Copy link
Contributor

@Alonexc Alonexc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PickBas
Copy link
Contributor Author

PickBas commented May 21, 2023

Resolved merge conflict

@xwm1992 xwm1992 merged commit 6fbfd7a into apache:master May 31, 2023
xuhongjia pushed a commit to Deckers-Ohana/eventmesh that referenced this pull request Mar 13, 2025
…th lambda (apache#3923) * [ISSUE apache#3909] Replaced anonymous new ChannelFutureListener() with lambda * Fixed checkstyle for source-connector-rocketmq * Fixed checkstyle for eventmesh-storage-rocketmq
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants