feat: Support log for Decimal128 and Decimal256

datafusion/common/src/scalar/mod.rs

@@ -1628,7 +1628,7 @@ impl ScalarValue {
  ) {
  return _internal_err!("Invalid precision and scale {err}");
  }
- if *scale <= 0 {
+ if *scale < 0 {
  return _internal_err!("Negative scale is not supported");
  }
  match i128::from(10).checked_pow((*scale + 1) as u32) {
@@ -1644,7 +1644,7 @@ impl ScalarValue {
  ) {
  return _internal_err!("Invalid precision and scale {err}");
  }
- if *scale <= 0 {
+ if *scale < 0 {
  return _internal_err!("Negative scale is not supported");
  }
  match i256::from(10).checked_pow((*scale + 1) as u32) {
@@ -5429,8 +5429,7 @@ mod tests {
  ScalarValue::new_ten(&DataType::Decimal128(7, 2)).unwrap(),
  ScalarValue::Decimal128(Some(1000), 7, 2)
  );
- // No negative or zero scale
- assert!(ScalarValue::new_ten(&DataType::Decimal128(5, 0)).is_err());
+ // No negative scale
  assert!(ScalarValue::new_ten(&DataType::Decimal128(5, -1)).is_err());
  // Invalid combination
  assert!(ScalarValue::new_ten(&DataType::Decimal128(0, 2)).is_err());
@@ -5452,8 +5451,7 @@ mod tests {
  ScalarValue::new_ten(&DataType::Decimal256(7, 2)).unwrap(),
  ScalarValue::Decimal256(Some(1000.into()), 7, 2)
  );
- // No negative or zero scale
- assert!(ScalarValue::new_ten(&DataType::Decimal256(5, 0)).is_err());
+ // No negative scale
  assert!(ScalarValue::new_ten(&DataType::Decimal256(5, -1)).is_err());
  // Invalid combination
  assert!(ScalarValue::new_ten(&DataType::Decimal256(0, 2)).is_err());

datafusion/functions/Cargo.toml

@@ -87,6 +87,8 @@ uuid = { version = "1.18", features = ["v4"], optional = true }
 [dev-dependencies]
 arrow = { workspace = true, features = ["test_utils"] }
 criterion = { workspace = true }
+ctor = { workspace = true }
+env_logger = { workspace = true }
 rand = { workspace = true }
 tokio = { workspace = true, features = ["macros", "rt", "sync"] }
 

datafusion/functions/src/lib.rs

@@ -191,6 +191,13 @@ pub fn register_all(registry: &mut dyn FunctionRegistry) -> Result<()> {
  Ok(())
 }
 
+#[cfg(test)]
+#[ctor::ctor]
+fn init() {
+ // Enable RUST_LOG logging configuration for test
+ let _ = env_logger::try_init();
+}
+
 #[cfg(test)]
 mod tests {
  use crate::all_default_functions;