Add proper filetypeForProducttype test coverage #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brody4hire reviewed Oct 18, 2019
brody4hire reviewed Oct 18, 2019
There was a problem hiding this comment.
I think this is ready to merge, right after PR #71 (assuming we have a green build). I am trusting you on the Stryker mutation coverage.
I did have one comment but it is not a blocker. We can always fix it later if we missed anything here. What do you think?
brody4hire approved these changes Oct 18, 2019
There was a problem hiding this comment.
Good to go, your disposition regarding the quotes looks perfect. Merging now.
I should be able to make a new build and confirm here or in issue #70.
Thanks again!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Resolves #70.