Skip to content

Conversation

@GitToTheHub
Copy link
Contributor

@GitToTheHub GitToTheHub commented Nov 9, 2025

  • Add a helper method for success callbacks that returns Status.OK with a boolean
  • It didn't exist a success method for a boolean result, but for JSONObject, JSONArray, String, byte[] and int

Platforms affected

Motivation and Context

During developing the plugin of cordova-plugin-local-notifications I noticed that the original author implemented a helper method for new PluginResult(PluginResult.Status.OK, success), but I wondered why success couldn't be directly called on CallbackContext.

Description

Testing

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary
- Add helper method for success callbacks that returns `Status.OK` with a boolean
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 60.79%. Comparing base (655aa0a) to head (1a229e3).

Additional details and impacted files
@@ Coverage Diff @@ ## master #1864 +/- ## ======================================= Coverage 60.79% 60.79% ======================================= Files 23 23 Lines 4811 4811 ======================================= Hits 2925 2925 Misses 1886 1886 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants