ui: show resize volume button to all users #1595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The resize volume is support on all major hypervisors (Xen, VMware, KVM). The hypervisor key is returned by the list volumes response only for admins but not for users or domain admin users. This removes the check, as the operation is supported on all major hypervisors that CloudStack supports. With this changes all users would see resize volume button in the UI. Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Contributor
| Thanks @rhtyd nice fix. Tested it and LGTM. Before: After: |
Member Author
| Thanks @remibergsma /cc @swill ? |
Contributor
| LGTM 👍 |
Contributor
| LGTM |
Member Author
| @swill this is a simple UI bugfix, please consider merging for 4.9.0 rc2 as well. |
asfgit pushed a commit that referenced this pull request Jul 18, 2016
ui: show resize volume button to all users The resize volume is support on all major hypervisors (Xen, VMware, KVM). The hypervisor key is returned by the list volumes response only for admins but not for users or domain admin users. This removes the check, as the operation is supported on all major hypervisors that CloudStack supports. With this bug fix all users would see resize volume button in the UI. /cc @swill * pr/1595: ui: show resize volume button to all users Signed-off-by: Will Stevens <williamstevens@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The resize volume is support on all major hypervisors (Xen, VMware, KVM).
The hypervisor key is returned by the list volumes response only for admins
but not for users or domain admin users. This removes the check, as the operation
is supported on all major hypervisors that CloudStack supports.
With this bug fix all users would see resize volume button in the UI.
/cc @swill