ARROW-17940: [Java][Gandiva] Implement Reserve for JavaBuffer #14323
Conversation
| |
| This PR is based on changes from #14310 so will need to wait for that to merge. |
| @github-actions crossbow submit java-jars |
| Revision: 3b1ffe4219384bad9839c364ade9cab1dddcb65c Submitted crossbow builds: ursacomputing/crossbow @ actions-d680acd16f
|
There was a problem hiding this comment.
Can you move this include with the other Arrow includes below?
There was a problem hiding this comment.
| if (ARROW_PREDICT_TRUE(new_size < capacity())) { | |
| if (ARROW_PREDICT_TRUE(new_size <= capacity())) { |
There was a problem hiding this comment.
I suppose we don't need to implement this because it's not used currently?
There was a problem hiding this comment.
Yes, it's not needed by gandiva
js8544 force-pushed the jinshang/implement_reserve_for_gandiva_java_buffer branch from 3b1ffe4 to d90fcf0 Compare | @github-actions crossbow submit java-jars |
| Revision: d90fcf01f4833bbe1d500c125a90ab999edcbb9e Submitted crossbow builds: ursacomputing/crossbow @ actions-73726f002e
|
js8544 force-pushed the jinshang/implement_reserve_for_gandiva_java_buffer branch from d90fcf0 to 34c7061 Compare | @github-actions crossbow submit java-jars |
| Revision: 34c7061 Submitted crossbow builds: ursacomputing/crossbow @ actions-2a8cd8ba9f
|
| Benchmark runs are scheduled for baseline = e21ae28 and contender = 49a53d2. 49a53d2 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
| ['Python', 'R'] benchmarks have high level of regressions. |
…#14323) See previous discussions at apache#14261 Authored-by: Jin Shang <shangjin1997@gmail.com> Signed-off-by: Antoine Pitrou <antoine@python.org>
3 participants
See previous discussions at #14261