[v3-0-test] Cherry pick Grid view optimization (#51805) #52718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dstandish requested review from bbovenzi, bugraoz93, ephraimbuddy, jason810496, jscheffl, pierrejeambrun, rawwar, ryanahamilton and shubhamraj-git as code owners 
boring-cyborg bot added area:API dstandish force-pushed the cherry-pick-grid-optimization branch from c42a629 to 7833b41 Compare 
kaxil force-pushed the cherry-pick-grid-optimization branch from 7833b41 to 291e279 Compare 
Member
| Rebased on latest |
The headline here is, with 6k tasks in a dag, loading time for 10 runs drops from 1.5m to < 10s in a quick local test. I split it into smaller more purpose-specific requests that each do less. So we have one request for just the structure, and another one for TI states (per dag run). I also find ways to stop refreshing when there's no active dag run (or the particular dag run is not active and its tis don't need refreshing. I also changed the "latest dag run" query (which checks for a new run triggered externally to be simpler dedicated endpoint. It runs every couple seconds even when there is nothing going on and now it takes 10ms instead of 300ms. (cherry picked from commit eaa8ca0) --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
kaxil force-pushed the cherry-pick-grid-optimization branch from 291e279 to 1cbb29f Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Cherry pick Grid view optimization (#51805)