Fix: DAGs are not marked as stale if the dags folder change #41433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
utkarsharma2 requested review from ephraimbuddy and jedcunningham as code owners 
boring-cyborg bot added the area:Scheduler 
utkarsharma2 commented Aug 13, 2024
Lee-W reviewed Aug 21, 2024
Member
| Is a test possible? |
Contributor Author
Yes, I'll add them. |
Contributor Author
utkarsharma2 force-pushed the FixDagParsing branch from bb61051 to 055192a Compare 
ephraimbuddy approved these changes Aug 27, 2024
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Contributor
| @utkarsharma2 , can you backport this to v2-10-test |
Contributor Author
| Thanks @ephraimbuddy I'll do that. |
utkarsharma2 added a commit to astronomer/airflow that referenced this pull request Aug 28, 2024
…1433) * Fix: DAGs are not marked as stale if the AIRFLOW__CORE__DAGS_FOLDER changes * Update airflow/dag_processing/manager.py * Add testcase * Add code comment * Update code comment * Update the logic for checking the current dag_directory * Update testcases * Remove unwanted code * Uncomment code * Add processor_subdir when creating processor_subdir * Fix test_retry_still_in_executor test * Remove config from test * Update airflow/dag_processing/manager.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * Update if condition for readability --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 9f30a41)
Contributor Author
| Cherry picked - #41829 |
utkarsharma2 added a commit that referenced this pull request Aug 28, 2024
…41829) * Fix: DAGs are not marked as stale if the AIRFLOW__CORE__DAGS_FOLDER changes * Update airflow/dag_processing/manager.py * Add testcase * Add code comment * Update code comment * Update the logic for checking the current dag_directory * Update testcases * Remove unwanted code * Uncomment code * Add processor_subdir when creating processor_subdir * Fix test_retry_still_in_executor test * Remove config from test * Update airflow/dag_processing/manager.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * Update if condition for readability --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 9f30a41)
ephraimbuddy added a commit to astronomer/airflow that referenced this pull request Aug 29, 2024
…pache#41433)" This reverts commit 9f30a41.
utkarsharma2 added a commit that referenced this pull request Sep 2, 2024
…41829) * Fix: DAGs are not marked as stale if the AIRFLOW__CORE__DAGS_FOLDER changes * Update airflow/dag_processing/manager.py * Add testcase * Add code comment * Update code comment * Update the logic for checking the current dag_directory * Update testcases * Remove unwanted code * Uncomment code * Add processor_subdir when creating processor_subdir * Fix test_retry_still_in_executor test * Remove config from test * Update airflow/dag_processing/manager.py Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> * Update if condition for readability --------- Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com> (cherry picked from commit 9f30a41)
2 tasks
utkarsharma2 added a commit to astronomer/airflow that referenced this pull request Sep 12, 2024
…pache#41433)" This reverts commit 9f30a41.
ephraimbuddy pushed a commit that referenced this pull request Sep 12, 2024
ephraimbuddy added a commit to astronomer/airflow that referenced this pull request Sep 13, 2024
…pache#41433) (apache#41829)" This reverts commit 996af78.
joaopamaral pushed a commit to joaopamaral/airflow that referenced this pull request Oct 21, 2024
…pache#41433)" (apache#42197) This reverts commit 9f30a41.
39 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes: #41432