Fix tasks API endpoint when DAG doesn't have start_date #40878
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
`start_date` is now optional, if there is no schedule for the DAG (apache#35356). Tasks, however, inherit the `start_date` of their DAG by default. So it's now possible for tasks to have no `start_date` as well. Closes: apache#40828
jedcunningham requested review from ashb, bbovenzi, ephraimbuddy, pierrejeambrun and ryanahamilton as code owners 
boring-cyborg bot added area:API 
eladkal approved these changes Jul 19, 2024
uranusjr approved these changes Jul 19, 2024
This was referenced Jul 19, 2024
romsharon98 pushed a commit to romsharon98/airflow that referenced this pull request Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
start_dateis now optional, if there is no schedule for the DAG (#35356). Tasks, however, inherit thestart_dateof their DAG by default. So it's now possible for tasks to have nostart_dateas well.Closes: #40828
I chose not to add a test for this case, but if someone feels strongly that I should, I can.