chore: Rewrite terraform_validate to common::per_dir_hook #404
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MaxymVlasov commented Jul 4, 2022
Collaborator Author
MaxymVlasov left a comment
MaxymVlasov left a comment There was a problem hiding this comment.
Leave some notes about future improvements, to avoid extra attention to them in this PR
yermulnik approved these changes Jul 4, 2022
MaxymVlasov force-pushed the refactor/terraform_validate branch from 00926cc to eea6c00 Compare MaxymVlasov added this to the Features implementing and cleanup without breaking changes milestone antonbabenko pushed a commit that referenced this pull request Jul 12, 2022
* Refactor: Rewrite `terraform_validate` to `common::per_dir_hook` * Add ability to specify `--hook-config` in future
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
That's one of many PRs to the
pre-releasebranch, each one will depend on the previous one.That is the way to include all that info in one release...
Also, close #402.