Feature tree #24
Merged
Feature tree #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
anshul-mohil commented Oct 22, 2018
| public class EntryPoint { | ||
| public static void main(String[] args) { | ||
| | ||
| SwapNElementsLinkedList obj = new SwapNElementsLinkedList(); |
There was a problem hiding this comment.
follow naming convention
| public class EntryPoint { | ||
| public static void main(String[] args) { | ||
| | ||
| SwapNElementsLinkedList obj = new SwapNElementsLinkedList(); |
There was a problem hiding this comment.
follow naming convention for variables
| @@ -0,0 +1,7 @@ | |||
| package com.anshul.interviewmagnasoft; | |||
| | |||
| public class Node { | |||
There was a problem hiding this comment.
Need to be inner class if no other class is using Node class
| import java.util.LinkedList; | ||
| import java.util.List; | ||
| | ||
| public class ChannelCollectionImpl implements ChannelCollection { |
There was a problem hiding this comment.
Elaborated comments missing on class declaration
anshul-mohil commented Oct 22, 2018
...amming-parent/datastructure_algo/src/main/java/com/anshul/interviewmagnasoft/EntryPoint.java Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
merging design pattern and build related commits