Skip to content

fix(common): support equality function in httpResource #60026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

cexbrayat
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The equal option was not passed to the underlying resource.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from atscott February 19, 2025 22:25
@angular-robot angular-robot bot added the area: common Issues related to APIs in the @angular/common package label Feb 19, 2025
@ngbot ngbot bot added this to the Backlog milestone Feb 19, 2025
@atscott atscott requested review from alxhub and removed request for atscott February 19, 2025 22:47
The `equal` option was not passed to the underlying resource.
@cexbrayat cexbrayat force-pushed the fix/http-resource-equal branch from 17dbdf8 to c021ccd Compare March 4, 2025 13:45
@alxhub alxhub added the target: patch This PR is targeted for the next patch release label Mar 4, 2025
@JeanMeche JeanMeche modified the milestones: Backlog, v20 candidates Mar 4, 2025
@thePunderWoman thePunderWoman added the action: merge The PR is ready for merge by the caretaker label Mar 5, 2025
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit 9225049.

The changes were merged into the following branches: main, 19.2.x

AndrewKushnir pushed a commit that referenced this pull request Mar 5, 2025
The `equal` option was not passed to the underlying resource. PR Close #60026
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: common Issues related to APIs in the @angular/common package target: patch This PR is targeted for the next patch release
5 participants