perf(view): inline and refactor view instantiation and hydration

[tbosch]

• Don’t convert DOM array into JS array via Array.slice
• Inline static methods for instantiation and hydration
• Misc cleanup

[googlebot]

CLAs look good, thanks!

[tbosch]

@rkirov Could you review this?

[tbosch]

Updates benchmark numbers (/cc @mhevery )

tree benchmark#createDom binary tree of depth 9

Name	test time (ms)	gc time (ms)	garbage (KB)	retained memory (KB)
Ng 2.0 JS:	mean: 55.22ms ± 2%	mean: 29.39ms	mean: 3445.24KB	mean: 3583.80KB
Baseline JS:	mean: 15.61ms ± 6%	mean: 8.73ms	mean: 170.65KB	mean: 482.53KB
Ng 1.3 JS:	mean: 112.28ms ± 2%	mean: 55.42ms	mean: 8383.62KB	mean: 6025.07KB
Baseline Dartium:	mean: 15.31ms ± 1%	mean: N/A	mean: N/A	mean: N/A
Ng 2.0 Dartium:	mean: 44.37ms ± 45%	mean: N/A	mean: N/A	mean: N/A
Baseline Dart2JS:	mean: 41.26ms ± 3%	mean: 12.96ms	mean: 865.14KB	mean: 528.36KB
Ng 2.0 Dart2JS:	mean: 112.00ms ± 1%	mean: 35.80ms	mean: 5795.41KB	mean: 3699.36KB
Ng 1.0 Dartium:	mean: 84.80ms ± 2%	mean: N/A	mean: N/A	mean: N/A
Ng 1.0 Dart2JS:	mean: 265.44ms ± 2%	mean: 75.62ms	mean: 631.93KB	mean: 15261.86KB

tree benchmark#destroyDom binary tree of depth 9

Name	test time (ms)	gc time (ms)	garbage (KB)	retained memory (KB)
Ng 2.0 JS:	mean: 7.51ms ± 13%	mean: 16.29ms	mean: 3011.27KB	mean: -2981.90KB
Baseline JS:	mean: 4.60ms ± 10%	mean: 11.12ms	mean: 196.49KB	mean: -193.38KB
Ng 1.3 JS:	mean: 11.95ms ± 10%	mean: 44.15ms	mean: 6131.41KB	mean: -5666.24KB
Baseline Dartium:	mean: 11.26ms ± 20%	mean: N/A	mean: N/A	mean: N/A
Ng 2.0 Dartium:	mean: 14.13ms ± 3%	mean: N/A	mean: N/A	mean: N/A
Baseline Dart2JS:	mean: 5.11ms ± 3%	mean: 15.50ms	mean: 229.11KB	mean: -185.61KB
Ng 2.0 Dart2JS:	mean: 8.54ms ± 13%	mean: 19.73ms	mean: 3097.99KB	mean: -3008.55KB
Ng 1.0 Dartium:	mean: 8.05ms ± 3%	mean: N/A	mean: N/A	mean: N/A
Ng 1.0 Dart2JS:	mean: 11.03ms ± 9%	mean: 53.91ms	mean: 14808.12KB	mean: -14634.97KB

[mhevery]

const?

[tbosch]

Not working in Dart. Will add a TODO

[kseamon]

@tbosch Can you rerun the benchmarks above? Supposedly performance bugs on the Dart side have been addressed.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}