Skip to content

Conversation

@IgorMinar
Copy link
Contributor

per discussion with @zzo...

This change causes the build system to write a log file into the tmp folder after each build.
This file contains command line arguments that tell karma about all the added/changed/removed files
from the last build. Karma can then use this list instead of doing internal globbing which can be
very expensive especially for hte dart builds that contain thousands of files.

Closes #2437

Review on Reviewable

@IgorMinar IgorMinar added the area: build & ci Related the build and CI infrastructure of the project label Jun 29, 2015
@IgorMinar IgorMinar added this to the alpha-29 milestone Jun 29, 2015
@IgorMinar
Copy link
Contributor Author

This doesn't address the initial bootstrap latency which @zzo partly improved via more efficient globbing in the recent karma canary.

@tbosch
Copy link
Contributor

tbosch commented Jun 29, 2015

Who can review this?

@IgorMinar IgorMinar added action: review The PR is still awaiting reviews from at least one requested reviewer and removed state: WIP labels Jun 30, 2015
@IgorMinar IgorMinar assigned alexeagle and unassigned IgorMinar Jun 30, 2015
@IgorMinar
Copy link
Contributor Author

maybe @alexeagle ?

gulpfile.js Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's with the 1100? should we at least log here if the length exceeds that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if it's more, we don't use the args at all and run karma without args which will work just fine, but will be slower.

the limit here is to avoid issues on windows where there is a limit for the length of a command send to the terminal.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all add more docs

@alexeagle
Copy link
Contributor

This works the same whether karma is running JS or Dart tests, right?
I don't know much about how karma will use this arg but I assume it will help :)

This change causes the build system to write a log file into the tmp folder after each build. This file contains command line arguments that tell karma about all the added/changed/removed files from the last build. Karma can then use this list instead of doing internal globbing which can be very expensive especially for hte dart builds that contain thousands of files. Closes angular#2437
@IgorMinar IgorMinar merged commit 7fc1ee6 into angular:master Jun 30, 2015
@IgorMinar
Copy link
Contributor Author

yes. this works both for js and dart.

I've made all the other changes and merged this in.

IgorMinar added a commit to IgorMinar/angular that referenced this pull request Jul 1, 2015
This is an alternative to angular#2778. All of the symlinks to packages directory within the test directory are not needed for running tests, so we can safely remove them. This removes 80k files from the test directory which significantly speeds up Karma. Closes angular#2437
IgorMinar added a commit that referenced this pull request Jul 1, 2015
This is an alternative to #2778. All of the symlinks to packages directory within the test directory are not needed for running tests, so we can safely remove them. This removes 80k files from the test directory which significantly speeds up Karma. Closes #2437
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: review The PR is still awaiting reviews from at least one requested reviewer area: build & ci Related the build and CI infrastructure of the project cla: yes

4 participants