Skip to content

fix(@ngtools/webpack): fix rebuild speed regression #8023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2017
Merged

fix(@ngtools/webpack): fix rebuild speed regression #8023

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/@ngtools/webpack/src/loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -568,7 +568,6 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }, source: s
.then(() => {
timeEnd(timeLabel + '.ngcLoader.AngularCompilerPlugin');
const result = plugin.getFile(sourceFileName);
const dependencies = plugin.getDependencies(sourceFileName);

if (result.sourceMap) {
// Process sourcemaps for Webpack.
Expand All @@ -585,7 +584,10 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }, source: s
throw new Error('TypeScript compilation failed.');
}

dependencies.forEach(dep => this.addDependency(dep));
// Dependencies must use system path separator.
const dependencies = plugin.getDependencies(sourceFileName);
dependencies.forEach(dep => this.addDependency(dep.replace(/\//g, path.sep)));

cb(null, result.outputText, result.sourceMap);
})
.catch(err => {
Expand Down Expand Up @@ -646,8 +648,9 @@ export function ngcLoader(this: LoaderContext & { _compilation: any }, source: s
_getResourcesUrls(refactor).forEach((url: string) => {
this.addDependency(path.resolve(path.dirname(sourceFileName), url));
});
// Dependencies must use system path separator.
_getImports(refactor, compilerOptions, plugin.compilerHost, plugin.moduleResolutionCache)
.forEach((importString: string) => this.addDependency(importString));
.forEach((dep) => this.addDependency(dep.replace(/\//g, path.sep)));
timeEnd(timeLabel + '.ngcLoader.AotPlugin.addDependency');
})
.then(() => {
Expand Down