fix(@angular/build): resolve "Controller is already closed" error in Karma #30653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
alan-agius4 added action: review 
alan-agius4 force-pushed the karma-options branch from 3bb2141 to c621772 Compare alan-agius4 force-pushed the karma-options branch 6 times, most recently from 9d404a8 to ef6092c Compare alan-agius4 added target: rc alan-agius4 force-pushed the karma-options branch 3 times, most recently from 6bb0cf1 to 4673259 Compare 13 tasks
alan-agius4 force-pushed the karma-options branch 2 times, most recently from f38af30 to 9bee394 Compare 
jkrems approved these changes Jul 7, 2025
packages/angular/build/src/builders/karma/application_builder.ts Outdated Show resolved Hide resolved
packages/angular/build/src/builders/karma/application_builder.ts Outdated Show resolved Hide resolved
| @@ -229,7 +229,8 @@ | |||
| }, | |||
| "watch": { | |||
| "type": "boolean", | |||
| "description": "Run build when files change." | |||
| "description": "Re-run tests when source files change.", | |||
There was a problem hiding this comment.
Double-checking: Was it ever a thing that the karma builder would default to non-watching outside of TTY?
| @@ -44,7 +44,7 @@ | |||
| }, | |||
| "watch": { | |||
| "type": "boolean", | |||
| "description": "Run build when files change." | |||
| "description": "Re-run tests when source files change. Defaults to `false` in TTY environments and `true` otherwise." | |||
There was a problem hiding this comment.
Is the default flipped here? I assume we do watch in TTY environments and don't outside of them? (Ref https://nodejs.org/api/tty.html#tty)
There was a problem hiding this comment.
I meant false in non-TTY.
…Karma This issue stems from the `Some of your tests did a full page reload` error, which occurs because `karmaOptions.client.clearContext` is set to `true` when `singleRun` is `false`, even though Karma is running in watch mode. Previously, the `watch` flag was configured inconsistently across multiple locations, leading to misalignment. Closes angular#30506
alan-agius4 force-pushed the karma-options branch from 9bee394 to 29bd9db Compare Descriptions for the "watch" option where not clear.
…lders This ensures a cleaner and easier to follow code and also avoid having the fix bugs in multiple places.
alan-agius4 force-pushed the karma-options branch from 29bd9db to 9e1d328 Compare alan-agius4 added action: merge 
| The changes were merged into the following branches: main, 20.1.x |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This issue stems from the
Some of your tests did a full page reloaderror, which occurs becausekarmaOptions.client.clearContextis set totruewhensingleRunisfalse, even though Karma is running in watch mode. Previously, thewatchflag was configured inconsistently across multiple locations, leading to misalignment.Closes #30506