Skip to content

fix(@angular/build): failed to proxy error for assets #30648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion packages/angular/build/src/builders/karma/application_builder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,22 @@ class AngularAssetsMiddleware {
return;
}

// Implementation of serverFile can be found here:
// https://github.com/karma-runner/karma/blob/84f85e7016efc2266fa6b3465f494a3fa151c85c/lib/middleware/common.js#L10
switch (file.origin) {
case 'disk':
this.serveFile(file.inputPath, undefined, res, undefined, undefined, /* doNotCache */ true);
break;
case 'memory':
// Include pathname to help with Content-Type headers.
this.serveFile(`/unused/${url.pathname}`, undefined, res, undefined, file.contents, true);
this.serveFile(
`/unused/${url.pathname}`,
undefined,
res,
undefined,
file.contents,
/* doNotCache */ false,
);
break;
}
}
Expand Down Expand Up @@ -508,6 +517,7 @@ async function initializeApplication(
scriptsFiles.push({
pattern: `${outputPath}/${outputName}`,
watched: false,
included: typeof scriptEntry === 'string' ? true : scriptEntry.inject !== false,
type: 'js',
});
}
Expand Down
3 changes: 0 additions & 3 deletions packages/angular/build/src/builders/karma/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,6 @@ function getBuiltInKarmaConfig(
'karma-jasmine-html-reporter',
'karma-coverage',
].map((p) => workspaceRootRequire(p)),
proxies: {
'/': '/base/',
},
jasmineHtmlReporter: {
suppressAll: true, // removes the duplicated traces
},
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/**
* @license
* Copyright Google LLC All Rights Reserved.
*
* Use of this source code is governed by an MIT-style license that can be
* found in the LICENSE file at https://angular.dev/license
*/

import { execute } from '../../index';
import { BASE_OPTIONS, KARMA_BUILDER_INFO, describeKarmaBuilder } from '../setup';

describeKarmaBuilder(execute, KARMA_BUILDER_INFO, (harness, setupTarget) => {
describe('Option: "scripts"', () => {
beforeEach(async () => {
await setupTarget(harness);
});

it(`should be able to access non injected script`, async () => {
await harness.writeFiles({
'src/test.js': `console.log('hello from test script.')`,
'src/app/app.component.ts': `
import { Component } from '@angular/core';
@Component({
selector: 'app-root',
standalone: false,
template: '<p>Hello World</p>'
})
export class AppComponent {
loadScript() {
return new Promise<void>((resolve, reject) => {
const script = document.createElement('script');
script.onload = () => resolve();
script.onerror = reject;
script.src = 'test.js';
document.body.appendChild(script);
});
}
}
`,
'src/app/app.component.spec.ts': `
import { TestBed } from '@angular/core/testing';
import { AppComponent } from './app.component';
describe('AppComponent', () => {
beforeEach(() => TestBed.configureTestingModule({
declarations: [AppComponent]
}));
it('should load script', async () => {
const fixture = TestBed.createComponent(AppComponent);
fixture.detectChanges();
await expectAsync(fixture.componentInstance.loadScript()).toBeResolved();
});
});`,
});

harness.useTarget('test', {
...BASE_OPTIONS,
scripts: [
{
input: 'src/test.js',
bundleName: 'test',
inject: false,
},
],
});

const { result } = await harness.executeOnce();
expect(result?.success).toBeTrue();
});
});
});