Skip to content

Conversation

@mohuk
Copy link
Contributor

@mohuk mohuk commented Sep 30, 2019

Subtracting the top space from image vh(viewport height) to remove scroll

Closes: #15596

Subtracting the top space from image vh(viewport height) to remove scroll angular#15596
@mohuk
Copy link
Contributor Author

mohuk commented Sep 30, 2019

@vikerman
Copy link
Contributor

Thanks for PR!

Can you share a screenshot on before and after so that it's easy to review? Thanks!

@mohuk
Copy link
Contributor Author

mohuk commented Oct 1, 2019

Sure.

Before
Before

After
After

@alan-agius4 alan-agius4 self-assigned this Oct 4, 2019
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the commit footer.

Can you please change #15596 to Closes: #15596?

Thanks.

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Oct 4, 2019
@vikerman vikerman merged commit bcbbc19 into angular:master Oct 7, 2019
@vikerman
Copy link
Contributor

vikerman commented Oct 7, 2019

Fixed the commit footer while squashing.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release

4 participants