This repository was archived by the owner on Apr 17, 2020. It is now read-only.
Add promise-polyfill to dependencies list for npm install #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
While the 'yarn' command seems to install promise-polyfill, 'npm install' doesn't. Although yarn is preferred for this course, it fails to find the Visual C++ compiler on Windows (using VS 2017 Community Edition on Windows 10), preventing node-sass from building properly. Thus it may be advised to explicitly include the promise-polyfill dependency to facilitate those on Windows who may be restricted to using npm install.
| Thank you @kamalgill, the PR is merged. Kind Regards, Vasco |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
While the 'yarn' command seems to install promise-polyfill, 'npm install' doesn't. Although yarn is preferred for this course, it fails to find the Visual C++ compiler on Windows (using VS 2017 Community Edition on Windows 10), preventing node-sass from building properly. Thus it may be advised to explicitly include the promise-polyfill dependency to facilitate those on Windows who may be restricted to using npm install.