This repository was archived by the owner on Sep 8, 2020. It is now read-only.
add optional debouncing #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Debouncing will no longer be a default action unless the user specifies debounce: true in the options.
Contributor Author
| Conflict: |
Contributor
| Thanks for posting this review. I am open to this change. I will review tonight and try to get all the open PRs merged in. Sorry for the delay. Don't worry about that error, I can take a look and fix it before merging. |
Contributor
| Thanks for the PR. I decided to leave debouncing default for now with the ability to disable it. I am going to open another ticket to change to throttle and allow debounce to be set by user with ng-model-options. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Debouncing will no longer be a default action unless the user specifies
debounce: truein the options. Relating to issue #256Motivation: Debouncing was causing unexpected behavior where data was being excluded when submitting or saving text from TinyMCE. Debouncing should be optional.